Conversation
- Remove user=request.user from typed tab table instantiation; django_tables2.Table does not accept this kwarg and NetBox 4.5.4 passes it through, causing TypeError. Per-user preferences are already applied by table.configure(request) called immediately after. - Read plugin version from package metadata (importlib.metadata) so it is defined only in pyproject.toml, not duplicated in __init__.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
TypeErrorcrash on the typed tab when usingnetbox_custom_objects0.4.6 on NetBox 4.5.4-Docker.Changes
Fixed
Table.__init__() got an unexpected keyword argument 'user'— removeduser=request.userfrom theCustomObjectTableinstantiation inviews/typed.py.django_tables2.Table.__init__does not accept this kwarg. It was redundant —table.configure(request)called immediately after already applies all per-user column preferences and ordering.Changed
pyproject.tomland read at runtime viaimportlib.metadata.version(). The duplicate hardcoded string in__init__.pyis gone.Testing
pytest tests/ -v)ruff checkandruff formatclean