Skip to content

Use openssh upstream's SSH_AUTH_INFO_0 if present#5

Open
opoplawski wants to merge 1 commit intoCERN-CERT:masterfrom
opoplawski:auth-info
Open

Use openssh upstream's SSH_AUTH_INFO_0 if present#5
opoplawski wants to merge 1 commit intoCERN-CERT:masterfrom
opoplawski:auth-info

Conversation

@opoplawski
Copy link
Copy Markdown

This seems to make things work on Fedora.

@opoplawski
Copy link
Copy Markdown
Author

Hmm, maybe this isn't the best approach as SSH_USER_AUTH has a different (though related) function in upstream openssh. Maybe just a way to define the name of the variable?

@Feandil
Copy link
Copy Markdown
Contributor

Feandil commented Nov 21, 2018

I think that the most forward looking change is to:

  • Rewrite the code (function names/comments/...) to point to SSH_AUTH_INFO_0
  • Replace the hardcoded environment variable name (SSH_AUTH_INFO_0) with a macro/static variable/..., defaulting to SSH_AUTH_INFO_0. On RHEL7, switch that value to SSH_USER_AUTH.

I guess we should also change the name of that pam module...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants