Skip to content

chore: add hash to entity macro derives#783

Open
cdc-as81 wants to merge 6 commits intomainfrom
cdc-as81-add-hash
Open

chore: add hash to entity macro derives#783
cdc-as81 wants to merge 6 commits intomainfrom
cdc-as81-add-hash

Conversation

@cdc-as81
Copy link
Collaborator

@cdc-as81 cdc-as81 commented Feb 18, 2026

No description provided.

github-actions bot added a commit that referenced this pull request Feb 18, 2026
@github-actions
Update bench-history.json (PR #783 @ e4caa69)
b89e19f
@github-actions
Copy link

github-actions bot commented Feb 18, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 3.1 ± 0.2 2.9 4.0 1.00
large_sir::entities 13.1 ± 1.1 12.4 19.9 4.28 ± 0.43

Criterion

Regressions:
  Group                                    Bench                                              Change  CI Lower  CI Upper
  ---------------------------------------  ------------------------------------------------  -------  --------  --------
  sample_entity_single_property_unindexed  10000                                             16.333%   13.433%   19.135%
  sample_entity_single_property_unindexed  100000                                             2.117%    1.771%    2.430%
  large_dataset                            bench_query_population_multi_indexed_entities     10.065%    9.778%   10.354%
  large_dataset                            bench_query_population_derived_property_entities   1.921%    1.570%    2.161%
  sampling                                 sampling_multiple_known_length_entities            1.009%    0.679%    1.279%

Improvements:
  Group                                    Bench                                              Change  CI Lower  CI Upper
  ---------------------------------------  ------------------------------------------------  -------  --------  --------
  sample_entity_single_property_indexed    10000                                             -0.795%   -1.230%   -0.475%
  sample_entity_single_property_unindexed  1000                                              -1.188%   -1.630%   -0.888%
  large_dataset                            bench_filter_unindexed_entity                     -7.473%  -12.243%   -2.528%
  sampling                                 sampling_multiple_unindexed_entities              -0.096%   -0.179%   -0.027%
  sampling                                 sampling_multiple_l_reservoir_entities            -1.976%   -2.564%   -1.304%
  sampling                                 sampling_single_l_reservoir_entities              -1.397%   -1.538%   -1.255%
  sampling                                 sampling_single_known_length_entities             -2.201%   -2.566%   -1.831%
  sample_entity_whole_population           10000                                             -1.546%   -2.043%   -1.100%
  sample_entity_whole_population           100000                                            -2.360%   -2.668%   -1.901%
  sample_entity_whole_population           1000                                              -2.372%   -2.743%   -2.012%

Unchanged:
  Group                                    Bench                                              Change  CI Lower  CI Upper
  ---------------------------------------  ------------------------------------------------  -------  --------  --------
  sample_entity_single_property_indexed    100000                                            -0.053%   -0.471%    0.533%
  sample_entity_single_property_indexed    1000                                              -0.319%   -0.914%    0.244%
  sample_entity_multi_property_indexed     10000                                              0.486%   -0.092%    1.084%
  sample_entity_multi_property_indexed     100000                                             0.210%   -0.275%    0.797%
  sample_entity_multi_property_indexed     1000                                               0.247%   -0.015%    0.460%
  large_dataset                            bench_filter_indexed_entity                       -8.329%  -19.953%    5.113%
  large_dataset                            bench_query_population_property_entities          -0.008%   -0.265%    0.240%
  large_dataset                            bench_match_entity                                -0.059%   -0.501%    0.259%
  large_dataset                            bench_query_population_multi_unindexed_entities   -0.203%   -0.587%    0.334%
  large_dataset                            bench_query_population_indexed_property_entities   0.291%   -0.038%    0.785%
  sampling                                 sampling_single_unindexed_entities                -0.210%   -0.527%    0.021%

@cdc-as81 cdc-as81 linked an issue Feb 19, 2026 that may be closed by this pull request
Add hash to list of entity macro derives #782
Open
@RobertJacobsonCDC
Copy link
Collaborator

RobertJacobsonCDC commented Feb 20, 2026

I remember now that the reason we didn't automatically derive Hash on Property<Entity> is because f64 does not implement Hash, and so something like this gives a compiler error:

 define_property!(struct Weight(f64), Person, default_const = Weight(0.0));

I think we should look for a way around this before committing this PR. I also have some notes about this on the wiki.

If we can't provide a blanket implementation of Hash for Property<E> using the implementation of hash_property_value, say, then we should generate an implementation in define_property!.

@cdc-as81 cdc-as81 marked this pull request as draft February 23, 2026 12:40
@RobertJacobsonCDC
Copy link
Collaborator

RobertJacobsonCDC commented Feb 26, 2026 •
edited
Loading

We can generate PartialEq, Eq, and Hash for each Property by defining them in terms of Property::hash_property_value applied to the canonical value. Equality becomes equality of the 128-bit hash, and Hash simply feeds that same u128 into the caller’s hasher. Under the explicit assumption that the 128-bit hash is collision-free in practice, this makes Eq and Hash consistent by construction and centralizes property semantics in a single hashing definition (including multi-property canonicalization), avoiding duplicated structural equality logic.

This is a relatively mechanical change to what the macro(s) generates. The relevant sources are:

  • src/entity/property.rs
  • src/macros/property_impl.rs

@RobertJacobsonCDC RobertJacobsonCDC mentioned this pull request Feb 26, 2026
Open
github-actions bot added a commit that referenced this pull request Feb 27, 2026
@github-actions
Update bench-history.json (PR #783 @ ad8bb1c)
23e0218
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 3.0 ± 0.0 2.9 3.1 1.00
large_sir::entities 13.0 ± 0.2 12.8 13.7 4.35 ± 0.09

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
counts single_property_unindexed_entities 12342.436% 12270.043% 12393.843%
large_dataset bench_query_population_property_entities 12304.585% 12258.843% 12343.085%
counts concrete_plus_derived_unindexed_entities 12113.742% 12061.277% 12153.507%
counts multi_property_unindexed_entities 9268.593% 9230.918% 9294.894%
large_dataset bench_query_population_multi_unindexed_entities 9235.408% 9144.939% 9332.648%
sample_entity sample_entity_single_property_unindexed 10000 8555.544% 8376.607% 8666.758%
sample_entity sample_entity_single_property_unindexed 1000 6694.099% 6615.827% 6775.270%
large_dataset bench_filter_unindexed_entity 6630.635% 6414.400% 6878.133%
sample_entity sample_entity_single_property_unindexed 100000 5373.455% 5359.920% 5385.366%
sampling sampling_single_unindexed_entities 5215.055% 5211.897% 5217.953%
sampling sampling_multiple_unindexed_entities 4634.726% 4619.841% 4648.640%
sampling sampling_single_unindexed_concrete_plus_derived_entities 2586.041% 2577.636% 2594.221%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti 2498.892% 2495.322% 2501.416%
large_dataset bench_match_entity 804.580% 802.690% 806.400%
large_dataset bench_query_population_derived_property_entities 665.333% 661.500% 668.690%
examples example-births-deaths 474.722% 473.243% 475.941%
examples example-basic-infection 64.023% 63.044% 64.894%
counts single_property_indexed_entities 19.657% 18.746% 20.802%
sample_entity sample_entity_whole_population 10000 12.200% 11.828% 12.695%
sample_entity sample_entity_whole_population 1000 12.042% 11.549% 12.426%
sample_entity sample_entity_whole_population 100000 11.388% 10.517% 12.385%
sample_entity sample_entity_single_property_indexed 10000 4.692% 4.019% 5.528%
sample_entity sample_entity_multi_property_indexed 100000 2.965% 2.566% 3.313%
sample_entity sample_entity_multi_property_indexed 1000 2.822% 2.475% 3.375%
indexing with_query_results_indexed_multi-property_entities 2.455% 1.373% 4.201%
counts reindex_after_adding_more_entities 2.452% 2.172% 2.728%
large_dataset bench_query_population_indexed_property_entities 2.102% 1.465% 2.686%
sample_entity sample_entity_single_property_indexed 100000 2.050% 1.211% 2.783%
large_dataset bench_query_population_multi_indexed_entities 1.944% 1.427% 2.388%
counts multi_property_indexed_entities 1.913% 1.544% 2.269%
sample_entity sample_entity_multi_property_indexed 10000 1.856% 1.582% 2.262%
sample_entity sample_entity_single_property_indexed 1000 1.841% 1.138% 2.450%
counts index_after_adding_entities 1.356% 1.178% 1.538%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
indexing query_people_single_indexed_property_entities -8.209% -8.333% -8.028%
sampling count_and_sampling_single_known_length_entities -8.157% -8.605% -7.607%
indexing query_people_count_multiple_individually_indexed_properties_enti -7.237% -7.347% -7.104%
indexing query_people_multiple_individually_indexed_properties_entities -5.094% -5.568% -4.731%
sampling sampling_single_l_reservoir_entities -4.994% -5.626% -4.495%
sampling sampling_multiple_l_reservoir_entities -4.731% -5.160% -4.403%
indexing with_query_results_multiple_individually_indexed_properties_enti -3.004% -4.992% -1.597%
indexing query_people_indexed_multi-property_entities -1.457% -1.730% -1.201%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
algorithm_benches algorithm_sampling_multiple_known_length 1.475% 0.801% 2.176%
indexing with_query_results_single_indexed_property_entities 1.382% 0.788% 1.988%
sampling sampling_single_known_length_entities 0.834% 0.312% 1.214%
indexing query_people_count_indexed_multi-property_entities -0.633% -1.128% -0.115%
sampling sampling_multiple_known_length_entities 0.519% -0.072% 0.997%
indexing query_people_count_single_indexed_property_entities 0.398% 0.103% 0.837%
large_dataset bench_filter_indexed_entity -0.307% -11.567% 13.689%
algorithm_benches algorithm_sampling_multiple_l_reservoir 0.301% -0.138% 0.665%
algorithm_benches algorithm_sampling_single_known_length -0.091% -0.593% 0.600%
algorithm_benches algorithm_sampling_single_l_reservoir -0.054% -0.177% 0.098%
algorithm_benches algorithm_sampling_single_rand_reservoir -0.040% -0.176% 0.103%

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 3.0 ± 0.0 2.9 3.1 1.00
large_sir::entities 13.7 ± 0.2 13.0 14.4 4.64 ± 0.09

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
counts single_property_unindexed_entities 12407.348% 12336.866% 12467.125%
large_dataset bench_query_population_property_entities 12334.295% 12247.891% 12409.602%
counts concrete_plus_derived_unindexed_entities 12266.233% 12227.310% 12310.769%
sample_entity sample_entity_single_property_unindexed 10000 9901.517% 9851.080% 9934.726%
counts multi_property_unindexed_entities 9169.985% 9154.184% 9183.453%
large_dataset bench_query_population_multi_unindexed_entities 8879.942% 8793.683% 8988.550%
sample_entity sample_entity_single_property_unindexed 1000 7010.196% 6955.582% 7059.698%
large_dataset bench_filter_unindexed_entity 6761.520% 6533.880% 7020.847%
sampling sampling_single_unindexed_entities 5160.615% 5147.498% 5172.126%
sampling sampling_multiple_unindexed_entities 4644.151% 4632.444% 4651.284%
sample_entity sample_entity_single_property_unindexed 100000 4519.444% 4504.033% 4536.589%
sampling sampling_single_unindexed_concrete_plus_derived_entities 2608.049% 2603.272% 2612.104%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti 2466.012% 2463.972% 2467.677%
large_dataset bench_match_entity 816.934% 813.247% 820.634%
large_dataset bench_query_population_derived_property_entities 688.405% 680.495% 696.548%
examples example-births-deaths 458.676% 456.377% 460.397%
examples example-basic-infection 46.768% 45.155% 48.591%
sampling sampling_multiple_l_reservoir_entities 24.623% 24.488% 24.728%
sample_entity sample_entity_whole_population 10000 17.105% 16.446% 17.552%
sample_entity sample_entity_whole_population 1000 14.642% 14.230% 15.089%
large_dataset bench_query_population_multi_indexed_entities 9.465% 8.317% 10.423%
sample_entity sample_entity_whole_population 100000 5.445% 4.697% 6.047%
indexing with_query_results_single_indexed_property_entities 2.266% 1.767% 2.862%
sampling sampling_multiple_known_length_entities 2.230% 1.651% 2.807%
sample_entity sample_entity_multi_property_indexed 1000 1.865% 1.195% 2.560%
sample_entity sample_entity_multi_property_indexed 10000 1.778% 1.379% 2.265%
large_dataset bench_query_population_indexed_property_entities 1.686% 1.193% 2.316%
counts single_property_indexed_entities 1.370% 1.096% 1.786%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
indexing query_people_single_indexed_property_entities -8.908% -11.406% -6.202%
sampling sampling_single_l_reservoir_entities -5.595% -6.217% -5.066%
indexing query_people_multiple_individually_indexed_properties_entities -5.271% -5.676% -4.604%
algorithm_benches algorithm_sampling_multiple_known_length -3.838% -4.376% -3.094%
indexing query_people_count_multiple_individually_indexed_properties_enti -2.921% -3.540% -2.302%
algorithm_benches algorithm_sampling_multiple_l_reservoir -2.808% -3.604% -2.220%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
sample_entity sample_entity_multi_property_indexed 100000 1.590% 0.908% 2.255%
counts multi_property_indexed_entities 1.294% 0.188% 2.060%
sampling count_and_sampling_single_known_length_entities -1.282% -1.782% -0.893%
sample_entity sample_entity_single_property_indexed 1000 1.265% 0.548% 2.046%
indexing with_query_results_indexed_multi-property_entities 1.165% 0.451% 1.790%
large_dataset bench_filter_indexed_entity 1.101% -11.338% 15.507%
indexing query_people_count_indexed_multi-property_entities -0.945% -1.171% -0.693%
algorithm_benches algorithm_sampling_single_rand_reservoir -0.915% -1.599% -0.024%
sample_entity sample_entity_single_property_indexed 10000 0.838% 0.201% 1.499%
indexing query_people_count_single_indexed_property_entities -0.702% -0.948% -0.473%
sample_entity sample_entity_single_property_indexed 100000 0.665% 0.040% 1.427%
counts reindex_after_adding_more_entities 0.593% 0.400% 0.798%
algorithm_benches algorithm_sampling_single_l_reservoir -0.425% -0.729% 0.048%
counts index_after_adding_entities -0.307% -0.608% -0.056%
indexing with_query_results_multiple_individually_indexed_properties_enti -0.285% -0.740% 0.357%
sampling sampling_single_known_length_entities 0.254% -0.251% 0.776%
indexing query_people_indexed_multi-property_entities 0.251% -0.243% 0.862%
algorithm_benches algorithm_sampling_single_known_length -0.210% -0.781% 0.627%

github-actions bot added a commit that referenced this pull request Feb 27, 2026
@github-actions
Update bench-history.json (PR #783 @ f2fa2cb)
b875503
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 3.0 ± 0.1 2.9 3.2 1.00
large_sir::entities 13.4 ± 0.8 13.0 17.9 4.48 ± 0.27

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_query_population_property_entities 12888.829% 12656.240% 13144.878%
counts single_property_unindexed_entities 12260.511% 12195.392% 12340.259%
counts concrete_plus_derived_unindexed_entities 12083.416% 12038.335% 12125.051%
counts multi_property_unindexed_entities 9114.240% 9069.199% 9150.538%
large_dataset bench_query_population_multi_unindexed_entities 8844.258% 8776.022% 8914.994%
sample_entity sample_entity_single_property_unindexed 10000 8698.322% 8671.686% 8728.850%
large_dataset bench_filter_unindexed_entity 6612.838% 6395.621% 6860.987%
sample_entity sample_entity_single_property_unindexed 1000 6238.679% 6201.939% 6275.546%
sample_entity sample_entity_single_property_unindexed 100000 5530.307% 5514.322% 5553.336%
sampling sampling_single_unindexed_entities 5191.621% 5185.327% 5196.253%
sampling sampling_multiple_unindexed_entities 4654.922% 4646.573% 4662.383%
sampling sampling_single_unindexed_concrete_plus_derived_entities 2610.266% 2604.372% 2615.343%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti 2484.659% 2482.552% 2486.773%
large_dataset bench_match_entity 825.185% 821.634% 827.976%
large_dataset bench_query_population_derived_property_entities 684.247% 681.171% 687.640%
examples example-births-deaths 472.980% 471.223% 474.644%
sample_entity sample_entity_whole_population 10000 48.560% 47.594% 49.634%
sample_entity sample_entity_whole_population 100000 47.430% 45.740% 49.190%
sample_entity sample_entity_whole_population 1000 46.758% 45.714% 47.979%
examples example-basic-infection 44.032% 42.016% 45.448%
sample_entity sample_entity_single_property_indexed 100000 5.729% 4.552% 6.904%
indexing with_query_results_single_indexed_property_entities 5.659% 4.992% 6.190%
indexing query_people_count_single_indexed_property_entities 3.835% 3.609% 4.044%
sample_entity sample_entity_multi_property_indexed 100000 3.230% 2.945% 3.493%
sample_entity sample_entity_single_property_indexed 1000 2.911% 2.148% 3.561%
sample_entity sample_entity_single_property_indexed 10000 2.910% 2.185% 3.487%
sample_entity sample_entity_multi_property_indexed 1000 2.844% 2.396% 3.200%
sample_entity sample_entity_multi_property_indexed 10000 2.783% 2.213% 3.403%
sampling sampling_multiple_known_length_entities 2.183% 1.692% 2.539%
large_dataset bench_query_population_multi_indexed_entities 1.922% 1.405% 2.454%
indexing with_query_results_indexed_multi-property_entities 1.784% 1.521% 2.124%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
indexing query_people_single_indexed_property_entities -7.926% -8.061% -7.805%
sampling sampling_single_l_reservoir_entities -5.530% -6.494% -4.715%
sampling sampling_multiple_l_reservoir_entities -3.852% -3.965% -3.765%
indexing query_people_multiple_individually_indexed_properties_entities -2.905% -3.042% -2.775%
counts multi_property_indexed_entities -2.751% -3.330% -2.195%
indexing query_people_indexed_multi-property_entities -1.849% -2.071% -1.543%
sampling count_and_sampling_single_known_length_entities -1.708% -1.991% -1.455%
counts single_property_indexed_entities -1.688% -1.914% -1.440%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
algorithm_benches algorithm_sampling_multiple_l_reservoir -1.006% -1.308% -0.680%
counts index_after_adding_entities -0.882% -1.147% -0.480%
large_dataset bench_filter_indexed_entity -0.803% -13.567% 13.449%
algorithm_benches algorithm_sampling_multiple_known_length -0.656% -0.963% -0.436%
indexing query_people_count_multiple_individually_indexed_properties_enti 0.544% 0.012% 1.033%
indexing with_query_results_multiple_individually_indexed_properties_enti -0.532% -0.978% -0.207%
indexing query_people_count_indexed_multi-property_entities 0.315% -0.287% 0.777%
algorithm_benches algorithm_sampling_single_known_length 0.093% -0.222% 0.519%
counts reindex_after_adding_more_entities -0.063% -0.666% 0.761%
algorithm_benches algorithm_sampling_single_l_reservoir -0.054% -0.221% 0.080%
large_dataset bench_query_population_indexed_property_entities 0.040% -0.372% 0.443%
algorithm_benches algorithm_sampling_single_rand_reservoir -0.034% -0.220% 0.134%
sampling sampling_single_known_length_entities 0.015% -0.444% 0.343%

github-actions bot added a commit that referenced this pull request Feb 27, 2026
@github-actions
Update bench-history.json (PR #783 @ f2fa2cb)
8fdd353
@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 2.4 ± 0.1 2.3 2.6 1.00
large_sir::entities 11.1 ± 0.2 10.9 11.7 4.71 ± 0.16

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
counts single_property_unindexed_entities 14994.487% 14911.245% 15100.622%
counts concrete_plus_derived_unindexed_entities 14645.397% 14575.555% 14689.700%
large_dataset bench_query_population_property_entities 12552.609% 12456.635% 12656.371%
counts multi_property_unindexed_entities 10642.190% 10585.326% 10695.913%
sample_entity sample_entity_single_property_unindexed 10000 8764.607% 8720.714% 8802.725%
large_dataset bench_query_population_multi_unindexed_entities 8758.824% 8731.763% 8779.574%
large_dataset bench_filter_unindexed_entity 6737.703% 6517.104% 6988.811%
sample_entity sample_entity_single_property_unindexed 1000 6243.321% 6213.549% 6275.098%
sample_entity sample_entity_single_property_unindexed 100000 5485.041% 5469.885% 5498.077%
sampling sampling_single_unindexed_entities 5260.327% 5252.762% 5266.500%
sampling sampling_multiple_unindexed_entities 4676.459% 4660.147% 4692.523%
sampling sampling_single_unindexed_concrete_plus_derived_entities 2690.877% 2686.602% 2694.746%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti 2501.016% 2499.779% 2502.140%
large_dataset bench_match_entity 837.445% 832.664% 842.616%
large_dataset bench_query_population_derived_property_entities 665.710% 661.939% 669.483%
examples example-births-deaths 481.224% 478.738% 483.663%
examples example-basic-infection 52.298% 51.222% 53.516%
sample_entity sample_entity_whole_population 1000 12.790% 12.172% 13.362%
sample_entity sample_entity_whole_population 10000 12.511% 12.225% 12.800%
sample_entity sample_entity_whole_population 100000 9.100% 8.258% 9.787%
sample_entity sample_entity_multi_property_indexed 1000 5.408% 4.551% 6.283%
sample_entity sample_entity_multi_property_indexed 100000 3.973% 3.616% 4.404%
counts multi_property_indexed_entities 3.652% 3.066% 3.996%
sample_entity sample_entity_multi_property_indexed 10000 3.605% 2.926% 4.290%
algorithm_benches algorithm_sampling_multiple_known_length 3.487% 3.173% 3.932%
algorithm_benches algorithm_sampling_multiple_l_reservoir 3.048% 2.827% 3.245%
large_dataset bench_query_population_indexed_property_entities 2.985% 2.438% 3.449%
sample_entity sample_entity_single_property_indexed 1000 2.290% 2.063% 2.543%
sample_entity sample_entity_single_property_indexed 10000 2.084% 1.778% 2.557%
sample_entity sample_entity_single_property_indexed 100000 1.940% 1.574% 2.442%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_query_population_multi_indexed_entities -7.199% -7.730% -6.603%
sampling sampling_single_l_reservoir_entities -6.301% -7.214% -5.527%
sampling sampling_multiple_l_reservoir_entities -4.963% -5.298% -4.688%
indexing query_people_count_multiple_individually_indexed_properties_enti -3.304% -4.024% -2.578%
indexing query_people_multiple_individually_indexed_properties_entities -2.818% -3.217% -2.422%
indexing query_people_count_indexed_multi-property_entities -2.701% -3.015% -2.431%
sampling sampling_multiple_known_length_entities -1.641% -2.002% -1.312%
counts reindex_after_adding_more_entities -1.385% -1.472% -1.291%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
sampling sampling_single_known_length_entities 1.556% 0.096% 3.250%
sampling count_and_sampling_single_known_length_entities 1.515% 0.191% 2.952%
counts single_property_indexed_entities 1.048% -0.192% 1.936%
algorithm_benches algorithm_sampling_single_l_reservoir -0.650% -0.836% -0.429%
indexing query_people_count_single_indexed_property_entities 0.502% -0.059% 0.991%
indexing query_people_indexed_multi-property_entities -0.466% -0.986% 0.153%
indexing with_query_results_single_indexed_property_entities -0.444% -0.969% 0.149%
counts index_after_adding_entities -0.394% -0.949% 0.026%
large_dataset bench_filter_indexed_entity -0.305% -11.901% 13.151%
algorithm_benches algorithm_sampling_single_rand_reservoir 0.245% -0.147% 0.659%
indexing with_query_results_indexed_multi-property_entities -0.208% -0.781% 0.385%
algorithm_benches algorithm_sampling_single_known_length -0.176% -0.605% 0.155%
indexing query_people_single_indexed_property_entities -0.141% -0.707% 0.239%
indexing with_query_results_multiple_individually_indexed_properties_enti -0.087% -0.445% 0.319%

github-actions bot added a commit that referenced this pull request Mar 1, 2026
@github-actions
Update bench-history.json (PR #783 @ f2fa2cb)
8b00448
github-actions bot added a commit that referenced this pull request Mar 2, 2026
@github-actions
Update bench-history.json (PR #783 @ f2fa2cb)
4c2b092
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 3.0 ± 0.0 2.9 3.1 1.00
large_sir::entities 14.2 ± 0.1 14.0 14.6 4.80 ± 0.07

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_query_population_property_entities 12391.650% 12333.175% 12430.455%
counts single_property_unindexed_entities 12159.198% 12037.980% 12260.027%
counts concrete_plus_derived_unindexed_entities 11990.734% 11916.656% 12073.756%
large_dataset bench_query_population_multi_unindexed_entities 9141.294% 9030.373% 9263.656%
counts multi_property_unindexed_entities 9126.502% 9105.297% 9146.801%
sample_entity sample_entity_single_property_unindexed 10000 8619.962% 8578.619% 8649.135%
large_dataset bench_filter_unindexed_entity 7500.018% 7245.479% 7788.347%
sample_entity sample_entity_single_property_unindexed 1000 6423.386% 6368.347% 6481.141%
sample_entity sample_entity_single_property_unindexed 100000 5384.713% 5364.518% 5400.785%
sampling sampling_single_unindexed_entities 5172.305% 5162.878% 5182.552%
sampling sampling_multiple_unindexed_entities 5119.868% 5109.117% 5131.709%
sampling sampling_single_unindexed_concrete_plus_derived_entities 2465.727% 2462.433% 2469.235%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti 2457.707% 2453.681% 2461.575%
large_dataset bench_match_entity 855.652% 849.160% 861.974%
large_dataset bench_query_population_derived_property_entities 727.504% 722.726% 733.610%
examples example-births-deaths 521.288% 517.468% 527.395%
examples example-basic-infection 61.774% 60.441% 63.502%
sample_entity sample_entity_whole_population 10000 10.222% 9.686% 10.799%
sample_entity sample_entity_whole_population 1000 9.938% 8.828% 10.794%
sample_entity sample_entity_whole_population 100000 9.784% 8.623% 10.988%
indexing query_people_single_indexed_property_entities 8.377% 6.211% 10.706%
sampling sampling_single_known_length_entities 7.841% 7.418% 8.275%
counts multi_property_indexed_entities 6.723% 5.996% 7.413%
algorithm_benches algorithm_sampling_multiple_l_reservoir 5.763% 5.471% 6.085%
indexing query_people_count_multiple_individually_indexed_properties_enti 4.374% 2.276% 6.288%
algorithm_benches algorithm_sampling_multiple_known_length 3.096% 1.436% 4.261%
sample_entity sample_entity_multi_property_indexed 1000 1.456% 1.010% 2.030%
counts reindex_after_adding_more_entities 1.272% 1.049% 1.497%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
sample_entity sample_entity_single_property_indexed 1000 -17.388% -17.992% -16.815%
sample_entity sample_entity_single_property_indexed 10000 -17.127% -17.567% -16.661%
sample_entity sample_entity_single_property_indexed 100000 -16.119% -16.547% -15.794%
indexing query_people_multiple_individually_indexed_properties_entities -13.328% -14.814% -11.941%
sampling sampling_single_l_reservoir_entities -13.256% -14.009% -12.575%
sampling sampling_multiple_l_reservoir_entities -8.129% -8.377% -7.891%
large_dataset bench_query_population_multi_indexed_entities -3.380% -3.687% -3.082%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_query_population_indexed_property_entities 1.153% 0.609% 1.512%
counts single_property_indexed_entities -1.091% -1.297% -0.818%
sample_entity sample_entity_multi_property_indexed 10000 0.930% 0.422% 1.308%
indexing with_query_results_indexed_multi-property_entities 0.922% 0.146% 1.645%
sampling count_and_sampling_single_known_length_entities 0.868% 0.083% 1.641%
counts index_after_adding_entities 0.732% 0.508% 1.056%
sample_entity sample_entity_multi_property_indexed 100000 0.561% 0.084% 0.875%
algorithm_benches algorithm_sampling_single_known_length -0.523% -1.242% 0.106%
indexing query_people_count_single_indexed_property_entities 0.453% -0.092% 0.995%
indexing query_people_count_indexed_multi-property_entities -0.410% -1.004% 0.091%
indexing with_query_results_single_indexed_property_entities -0.295% -0.886% 0.167%
algorithm_benches algorithm_sampling_single_rand_reservoir -0.252% -0.813% 0.173%
algorithm_benches algorithm_sampling_single_l_reservoir 0.220% -0.387% 1.230%
indexing query_people_indexed_multi-property_entities -0.218% -0.582% 0.162%
sampling sampling_multiple_known_length_entities -0.179% -0.584% 0.328%
large_dataset bench_filter_indexed_entity -0.050% -12.778% 14.137%
indexing with_query_results_multiple_individually_indexed_properties_enti -0.035% -0.365% 0.363%

@cdc-as81 cdc-as81 marked this pull request as ready for review March 2, 2026 18:02
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 3.0 ± 0.1 2.9 3.3 1.00
large_sir::entities 14.2 ± 0.5 13.5 16.2 4.72 ± 0.20

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
sample_entity sample_entity_single_property_unindexed 1000 18.491% 18.092% 18.803%
indexing query_people_single_indexed_property_entities 10.153% 7.752% 12.562%
sample_entity sample_entity_whole_population 1000 6.977% 6.485% 7.438%
counts reindex_after_adding_more_entities 1.345% 1.021% 1.630%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
sample_entity sample_entity_single_property_unindexed 10000 -7.330% -10.823% -3.743%
large_dataset bench_match_entity -5.414% -5.608% -5.176%
examples example-basic-infection -3.220% -3.551% -2.933%
indexing query_people_indexed_multi-property_entities -3.185% -3.619% -2.743%
examples example-births-deaths -2.200% -3.631% -1.206%
indexing query_people_count_indexed_multi-property_entities -2.086% -2.434% -1.623%
sampling sampling_multiple_l_reservoir_entities -1.257% -1.332% -1.180%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_query_population_multi_unindexed_entities 1.494% 0.584% 2.475%
indexing query_people_multiple_individually_indexed_properties_entities -1.421% -2.350% -0.380%
counts multi_property_indexed_entities -1.333% -1.787% -0.976%
sampling sampling_multiple_unindexed_entities -1.317% -1.768% -0.877%
sampling sampling_single_l_reservoir_entities -1.260% -1.749% -0.846%
indexing with_query_results_indexed_multi-property_entities 1.194% 0.880% 1.456%
sample_entity sample_entity_whole_population 100000 1.160% 0.546% 1.776%
counts index_after_adding_entities 0.878% 0.775% 0.990%
sample_entity sample_entity_whole_population 10000 0.782% 0.312% 1.145%
algorithm_benches algorithm_sampling_single_known_length 0.756% 0.301% 1.323%
algorithm_benches algorithm_sampling_multiple_known_length -0.695% -1.073% -0.197%
sampling sampling_single_known_length_entities 0.590% 0.129% 0.932%
sampling sampling_single_unindexed_concrete_plus_derived_entities 0.565% 0.379% 0.739%
counts single_property_unindexed_entities -0.545% -1.183% -0.016%
sample_entity sample_entity_multi_property_indexed 100000 -0.526% -1.285% 0.195%
counts multi_property_unindexed_entities 0.520% -0.665% 1.690%
algorithm_benches algorithm_sampling_multiple_l_reservoir -0.438% -0.633% -0.219%
indexing with_query_results_single_indexed_property_entities 0.435% -0.212% 1.214%
large_dataset bench_query_population_derived_property_entities -0.427% -0.973% 0.084%
sampling sampling_multiple_known_length_entities 0.423% -0.025% 1.143%
large_dataset bench_query_population_indexed_property_entities 0.400% -0.416% 1.503%
sample_entity sample_entity_multi_property_indexed 10000 0.389% -0.107% 1.101%
sample_entity sample_entity_single_property_indexed 1000 -0.385% -0.853% 0.022%
large_dataset bench_filter_indexed_entity 0.373% -11.975% 14.850%
sample_entity sample_entity_single_property_indexed 100000 -0.347% -0.919% 0.175%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti 0.295% 0.190% 0.407%
counts single_property_indexed_entities 0.264% -0.177% 0.603%
large_dataset bench_filter_unindexed_entity 0.257% -4.552% 5.450%
indexing query_people_count_single_indexed_property_entities -0.222% -0.929% 0.717%
large_dataset bench_query_population_property_entities -0.196% -0.663% 0.346%
algorithm_benches algorithm_sampling_single_l_reservoir 0.190% 0.042% 0.314%
sample_entity sample_entity_multi_property_indexed 1000 -0.179% -0.633% 0.191%
indexing with_query_results_multiple_individually_indexed_properties_enti -0.166% -0.761% 0.644%
sample_entity sample_entity_single_property_unindexed 100000 0.158% -0.241% 0.679%
algorithm_benches algorithm_sampling_single_rand_reservoir -0.113% -0.560% 0.218%
sampling sampling_single_unindexed_entities 0.100% -0.009% 0.222%
indexing query_people_count_multiple_individually_indexed_properties_enti -0.051% -0.850% 0.742%
sample_entity sample_entity_single_property_indexed 10000 0.051% -0.258% 0.340%
sampling count_and_sampling_single_known_length_entities 0.032% -0.452% 0.411%
large_dataset bench_query_population_multi_indexed_entities 0.029% -0.563% 0.527%
counts concrete_plus_derived_unindexed_entities -0.011% -0.671% 0.603%

github-actions bot added a commit that referenced this pull request Mar 2, 2026
@github-actions
Update bench-history.json (PR #783 @ 5d97354)
963809f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertJacobsonCDC RobertJacobsonCDC Awaiting requested review from RobertJacobsonCDC

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add hash to list of entity macro derives

2 participants

@cdc-as81 @RobertJacobsonCDC