Merged
Conversation
damonbayer
reviewed
Jul 30, 2025
Collaborator
Author
|
Fixed via b1da630 |
damonbayer
reviewed
Jul 30, 2025
damonbayer
reviewed
Jul 30, 2025
damonbayer
approved these changes
Jul 30, 2025
Collaborator
damonbayer
left a comment
There was a problem hiding this comment.
Thanks @AFg6K7h4fhy2!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the full scope of this PR, please refer to issue #75 .
Specifically, this PR adds:
Allunderneath the model selectbox that selects all models.Noneunderneath the model selectbox that de-selects all models._cut_observed_to_forecastthat truncates the observations to beextra_weekslonger than the minimum forecast date.Somewhat out-of-scope but still useful, this PR also adds:
target_selection_uiandmodel_selection_uiin place ofmodel_and_target_selection_ui, to keep the code more organized and atomic; corresponding updates have been made inmain.location_selection_uiandreference_date_selection_uiin place oflocation_and_reference_data_ui, again to keep the code more organized and atomic; corresponding updates have been made inmain.