Conversation
…racefully_in_both_baseline_and_ensemble_forecast_generation
sbidari
reviewed
Jan 30, 2026
sbidari
reviewed
Jan 30, 2026
sbidari
requested changes
Jan 30, 2026
Collaborator
sbidari
left a comment
There was a problem hiding this comment.
It looks like some tests are failing. Can you update the failing tests?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
========================================
- Coverage 9.96% 9.66% -0.31%
========================================
Files 12 12
Lines 1144 1180 +36
========================================
Hits 114 114
- Misses 1030 1066 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sbidari
reviewed
Feb 4, 2026
sbidari
reviewed
Feb 4, 2026
sbidari
reviewed
Feb 4, 2026
sbidari
requested changes
Feb 4, 2026
Collaborator
sbidari
left a comment
There was a problem hiding this comment.
See comments regarding support for flu
sbidari
reviewed
Feb 6, 2026
sbidari
reviewed
Feb 6, 2026
sbidari
reviewed
Feb 6, 2026
sbidari
reviewed
Feb 6, 2026
sbidari
reviewed
Feb 6, 2026
sbidari
reviewed
Feb 6, 2026
sbidari
reviewed
Feb 10, 2026
sbidari
reviewed
Feb 10, 2026
…racefully_in_both_baseline_and_ensemble_forecast_generation
…racefully_in_both_baseline_and_ensemble_forecast_generation
sbidari
reviewed
Feb 10, 2026
sbidari
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
supported_diseasesconstant; exportedc("covid", "rsv", "flu")vector inutils.R, which replaces hardcodedc("covid", "rsv")checks.get_unique_targets()function: reads target suffixes from hub time-series data for a given diseaseget_target_label()function: maps target suffixes to human-readable labels.generate_hub_baseline()with targets support: accepts optional targets parameter & defaults to all unique targets in time-series.generate_hub_ensemble()with targets support (same as previous point)get_hub_name(),get_hub_repo_name(), andget_disease_name().How targets work with the ensemble and baseline forecast generation:
get_unique_targets()reads target suffixes fromtarget-data/time-series.targets = NULL, which gets all unique targets .targetsas optional JSON array, defaults to all.