Skip to content

feat(tasks): add visual indicator for unsynced local changes #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShivaGupta-14 wants to merge 1 commit into
base: main
Choose a base branch
from
+514 −11
Open

feat(tasks): add visual indicator for unsynced local changes #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 48 additions & 4 deletions frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx
View file
Open in desktop
Copy link
Contributor Author

@ShivaGupta-14 ShivaGupta-14 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shows animated unsynced badge when task has local changes pending sync. Added aria-labels for accessibility

Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const TaskDialog = ({
onMarkComplete,
onMarkDeleted,
isOverdue,
isUnsynced,
}: EditTaskDialogProps) => {
const handleDialogOpenChange = (open: boolean) => {
if (open) {
Expand Down Expand Up @@ -128,6 +129,11 @@ export const TaskDialog = ({
{task.project === '' ? '' : task.project}
</Badge>
)}
{isUnsynced && (
<Badge variant={'destructive'} className="animate-pulse">
Unsynced
</Badge>
)}
</TableCell>
<TableCell className="py-2">
<Badge
Expand Down Expand Up @@ -204,6 +210,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="save"
onClick={() => {
onSaveDescription(
task,
Expand All @@ -217,6 +224,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="cancel"
onClick={handleCancelClick}
>
<XIcon className="h-4 w-4 text-red-500" />
Expand All @@ -229,6 +237,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() => handleEditClick(task.description)}
>
<PencilIcon className="h-4 w-4 text-gray-500" />
Expand Down Expand Up @@ -276,6 +285,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="save"
onClick={() => {
onSaveDueDate(task, editState.editedDueDate);
onUpdateState({ isEditingDueDate: false });
Expand All @@ -286,6 +296,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="cancel"
onClick={() =>
onUpdateState({
editedDueDate: task.due || '',
Expand All @@ -302,6 +313,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() => {
onUpdateState({
isEditingDueDate: true,
Expand Down Expand Up @@ -361,6 +373,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="save"
onClick={() => {
onSaveStartDate(task, editState.editedStartDate);
onUpdateState({ isEditingStartDate: false });
Expand All @@ -372,6 +385,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="cancel"
onClick={() =>
onUpdateState({
editedStartDate: task.start || '',
Expand All @@ -388,6 +402,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() => {
onUpdateState({
isEditingStartDate: true,
Expand Down Expand Up @@ -444,6 +459,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="save"
onClick={() => {
onSaveEndDate(task, editState.editedEndDate);
onUpdateState({ isEditingEndDate: false });
Expand All @@ -454,6 +470,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="cancel"
onClick={() =>
onUpdateState({
editedEndDate: task.end || '',
Expand All @@ -470,6 +487,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() => {
onUpdateState({
isEditingEndDate: true,
Expand Down Expand Up @@ -526,6 +544,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="save"
onClick={() => {
onSaveWaitDate(task, editState.editedWaitDate);
onUpdateState({ isEditingWaitDate: false });
Expand All @@ -537,6 +556,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="cancel"
onClick={() =>
onUpdateState({
editedWaitDate: task.wait || '',
Expand All @@ -553,6 +573,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() => {
onUpdateState({
isEditingWaitDate: true,
Expand Down Expand Up @@ -600,6 +621,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() => {
onUpdateState({
isEditingDepends: true,
Expand Down Expand Up @@ -658,7 +680,10 @@ export const TaskDialog = ({
Add Dependency
</Button>
{editState.dependsDropdownOpen && (
<div className="absolute left-0 top-full mt-1 z-50 w-full bg-background border rounded-md shadow-lg max-h-60 overflow-y-auto">
<div
data-testid="dependency-dropdown"
className="absolute left-0 top-full mt-1 z-50 w-full bg-background border rounded-md shadow-lg max-h-60 overflow-y-auto"
>
<Input
type="text"
placeholder="Search tasks..."
Expand Down Expand Up @@ -716,6 +741,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="save"
onClick={() => {
onSaveDepends(task, editState.editedDepends);
onUpdateState({
Expand All @@ -729,6 +755,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="cancel"
onClick={() => {
onUpdateState({
isEditingDepends: false,
Expand Down Expand Up @@ -770,6 +797,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="save"
onClick={() => {
onSavePriority(task, editState.editedPriority);
onUpdateState({ isEditingPriority: false });
Expand All @@ -780,6 +808,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="cancel"
onClick={() => {
onUpdateState({
editedPriority: task.priority || 'NONE',
Expand All @@ -806,6 +835,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() =>
onUpdateState({
editedPriority: task.priority || 'NONE',
Expand Down Expand Up @@ -840,6 +870,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="save"
onClick={() => {
onSaveProject(task, editState.editedProject);
onUpdateState({ isEditingProject: false });
Expand All @@ -850,6 +881,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="cancel"
onClick={() =>
onUpdateState({
editedProject: task.project,
Expand All @@ -867,6 +899,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() => {
onUpdateState({
editedProject: task.project,
Expand Down Expand Up @@ -929,28 +962,28 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="Save tags"
onClick={() => {
onSaveTags(task, editState.editedTags);
onUpdateState({
isEditingTags: false,
editTagInput: '',
});
}}
aria-label="Save tags"
>
<CheckIcon className="h-4 w-4 text-green-500" />
</Button>
<Button
variant="ghost"
size="icon"
aria-label="Cancel editing tags"
onClick={() => {
onUpdateState({
isEditingTags: false,
editedTags: task.tags || [],
editTagInput: '',
});
}}
aria-label="Cancel editing tags"
>
<XIcon className="h-4 w-4 text-red-500" />
</Button>
Expand Down Expand Up @@ -1003,6 +1036,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() =>
onUpdateState({
isEditingTags: true,
Expand Down Expand Up @@ -1059,6 +1093,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="save"
onClick={() => {
onSaveEntryDate(task, editState.editedEntryDate);
onUpdateState({ isEditingEntryDate: false });
Expand All @@ -1070,6 +1105,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="cancel"
onClick={() =>
onUpdateState({
isEditingEntryDate: false,
Expand All @@ -1090,6 +1126,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() =>
onUpdateState({
isEditingEntryDate: true,
Expand Down Expand Up @@ -1159,6 +1196,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="save"
onClick={() =>
onSaveRecur(task, editState.editedRecur)
}
Expand All @@ -1168,6 +1206,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="cancel"
onClick={() =>
onUpdateState({
isEditingRecur: false,
Expand All @@ -1184,6 +1223,7 @@ export const TaskDialog = ({
<Button
variant="ghost"
size="icon"
aria-label="edit"
onClick={() => {
onUpdateState({
isEditingRecur: true,
Expand Down Expand Up @@ -1251,7 +1291,10 @@ export const TaskDialog = ({
{task.status == 'pending' ? (
<Dialog>
<DialogTrigger asChild className="mr-5">
<Button id={`mark-task-complete-${task.id}`}>
<Button
id={`mark-task-complete-${task.id}`}
aria-label="complete task"
>
Mark As Completed <Key lable="c" />
</Button>
</DialogTrigger>
Expand Down Expand Up @@ -1291,6 +1334,7 @@ export const TaskDialog = ({
id={`mark-task-as-deleted-${task.id}`}
className="mr-4"
variant={'destructive'}
aria-label="delete task"
>
<Trash2Icon />
<Key lable="d" />
Expand Down
Loading
Loading