Skip to content

Fix Vec::from_raw_parts UB in string_to_c_chars #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
THE-Amrit-mahto-05 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

Fix Vec::from_raw_parts UB in string_to_c_chars #2094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/rust/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,11 @@ pub fn null_pointer<T>() -> *mut T {
use std::os::raw::c_char;

pub fn string_to_c_chars(strs: Vec<String>) -> *mut *mut c_char {
let mut c_strs: Vec<*mut c_char> = Vec::new();
let mut c_strs: Vec<*mut c_char> = Vec::with_capacity(strs.len());
for s in strs {
c_strs.push(string_to_c_char(&s));
}
c_strs.shrink_to_fit();
let ptr = c_strs.as_mut_ptr();
std::mem::forget(c_strs);
ptr
Expand Down
Loading