Skip to content

Replace static buffer with dynamic allocation in writercwtdata() #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AhmedAlian7 wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −1
Open

Replace static buffer with dynamic allocation in writercwtdata() #2092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/lib_ccx/output.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,22 @@ void writercwtdata(struct lib_cc_decode *ctx, const unsigned char *data, struct
LLONG currfts = ctx->timing->fts_now + ctx->timing->fts_global;
static uint16_t cbcount = 0;
static int cbempty = 0;
static unsigned char cbbuffer[0xFFFF * 3]; // TODO: use malloc
static unsigned char *cbbuffer = NULL;
static int cbbuffer_initialized = 0;
static unsigned char cbheader[8 + 2];

if (!cbbuffer_initialized)
{
cbbuffer = (unsigned char *)malloc(0xFFFF * 3);
if (cbbuffer == NULL)
{
mprint("Error: Failed to allocate memory for cbbuffer\n");
return;
}
cbbuffer_initialized = 1;
dbg_print(CCX_DMT_VERBOSE, "Allocated RCWT buffer (%d bytes)\n", 0xFFFF * 3);
}

if ((prevfts != currfts && prevfts != -1) || data == NULL || cbcount == 0xFFFF)
{
// Remove trailing empty or 608 padding caption blocks
Expand Down
Loading