Add JSON output format for file report (-out=report=json)#2070
Closed
Apprentice2907 wants to merge 2 commits intoCCExtractor:masterfrom
Closed
Add JSON output format for file report (-out=report=json)#2070Apprentice2907 wants to merge 2 commits intoCCExtractor:masterfrom
Apprentice2907 wants to merge 2 commits intoCCExtractor:masterfrom
Conversation
Contributor
|
Closing this PR due to multiple issues: 1. Build Failures - Doesn't CompileThe Rust code references fields and types that don't exist in the codebase: The PR modifies
2. Mixed ConcernsThe PR combines unrelated changes:
These should be separate PRs. 3. Broken MarkdownThe README changes have an unclosed code block: ```bash
ccextractor input.ts --timestamp-map -o output.vttMissing the closing ``` fence. 4. Duplicates Existing WorkPR #2020 from x15sr71 already implements JSON output for
Before submitting a new implementation, please review existing PRs for the same feature. If you'd like to contribute JSON report output, please:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Summary
This pull request adds machine-readable JSON output for file reports using:
-out=report=json
Behavior
JSON Report Content
Implementation Notes