docs/debug: add verbose log when user data is skipped#2045
docs/debug: add verbose log when user data is skipped#2045pranavshar223 wants to merge 3 commits intoCCExtractor:masterfrom
Conversation
|
Hi maintainers, It looks like the |
|
My changes are limited to documentation and verbose debug logging in Please let me know if you’d prefer me to:
Thanks! |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit d494286...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit c65fb08...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
cfsmp3
left a comment
There was a problem hiding this comment.
The documentation and debug logging changes to userdata.rs look good, but this PR has issues that need to be fixed before merging:
1. Revert linux/pre-build.sh changes
This file should not be modified. The diff shows 34 additions / 34 deletions but the content is identical - this is a CRLF line ending issue from Windows development.
Shell scripts must have LF (Unix) line endings. CRLF will break the script on Linux with "bad interpreter" errors.
Fix: Revert this file to match master, or run:
git checkout master -- linux/pre-build.sh2. Configure git to handle line endings
To prevent this in future PRs, configure git:
git config --global core.autocrlf inputOr add a .gitattributes entry (already exists in repo - ensure it's working).
3. Clean up commit history (optional but recommended)
The commits "retry the test" and "restore all changes" add noise. Consider squashing into a single clean commit.
Once the pre-build.sh changes are reverted, this PR is ready to merge.
[IMPROVEMENT]
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
What this PR does
src/rust/src/es/userdata.rsWhy this is useful
userdata.rscontains complex legacy parsing logic for multiple caption standards.The added documentation and logging improve readability and debuggability without
changing runtime behavior.
Scope