fix(ts): allow manual streamtype override for private streams#2009
fix(ts): allow manual streamtype override for private streams#2009pulk17 wants to merge 3 commits intoCCExtractor:masterfrom
Conversation
|
I see "no captions were found" after. Each PR needs to show a real life improvement. Do you have any sample in which by doing this we are now able to extract captions? |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit c65fb08...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit c65fb08...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
[FIX] ts: Allow manual streamtype override for private streams causing fatal errors
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Summary
Fixed a logic bug in
ts_tables.cwhere the parser would trigger a fatal error ("I can't tell the stream type") for private streams (0x80-0xFF), even if the user explicitly provided--streamtype.The Issue
When parsing a PMT with private streams (common in M2TS files with PGS subtitles), the code checks if the stream type is private and immediately exits with a fatal error requesting manual selection.
The error logic failed to check if
ccx_options.demux_cfg.ts_forced_streamtypewas already set by the user via the CLI arguments. This made it impossible to force-read private streams, as the application would crash before applying the user's override.The Fix
Added a check to verify if the user has already manually set the stream type (via
--streamtype).Verification
Tested with
hitman_cut.m2ts(a sample with missing PMT/Private Stream) and00000.m2ts(PGS streams).Command:
ccextractor input.m2ts --datapid 4608 --streamtype 6