fix: gs10 data partition; container syntax; input file name collision in Octopus; AnnotSV missing db; name tag#111
Merged
kelly-sovacool merged 11 commits intomainfrom Feb 12, 2026
Merged
Conversation
gs10 data partition; container syntax issue; input file name collision in Octopus variant calling; AnnotSV database missing issue;gs10 data partition; container syntax; input file name collision in Octopus; AnnotSV missing db; name tag
kelly-sovacool
approved these changes
Feb 12, 2026
Member
|
I went ahead and added a few lines to the changelog. Thanks for fixing these bugs Samarth! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR address various issues:
1. Removed
/gs10data partition from ci_stub.config and nextflow.configfixes #110
2. Changed continer syntax
container = "${params.containers}"tocontainer "${params.containers}"for all local modulesNULLleading to errors likefastp command not found3. Fix input file name collision in Octopus variant calling
Nextflow was failing with input file name collision errors when running Octopus variant caller:
The
bambyintervalchannel was being reused across multiple variant calling processes (mutect2, vardict, varscan, octopus). This caused duplicate interval files to be processed and collected bygroupTuple(), resulting in the same VCF file appearing multiple times in the input lists.Added
.unique()deduplication after sorting VCF and index files in the Octopus workflow sections:workflows/tumoronly.nf: Added.unique()to Octopus tumor-only workflowworkflows/tumornormal.nf: Added.unique()to Octopus paired (TN) and tumor-only workflows4. Fix AnnotSV database path resolution in tumor-only SV workflows
AnnotSV was failing due to incorrect or inconsistent database path configuration (-annotationsDir) in SV workflows. The process did not provide a annotsv_db path, which led to default path from within the container which did not exist inside the container, causing AnnotSV to fail during configuration loading.
This PR standardizes and externalizes the AnnotSV database configuration using genome-specific parameters.
5. Fix undefined tag variable in
bwamem2processThe
bwamem2process was using an undefined variablenamein thetagdirective, which would cause the tag to be empty or throw an error.Process input parameter is named
samplename, but thetagdirective was referencingnamePR Checklist
(
Strikethroughany points that are not applicable.)[ ] Write unit tests for any new features, bug fixes, or other code changes.testing framework not yet implemented[] Update docs if there are any API changes.[ ] If a new nextflow process is implemented, define the processcontainerandstub.CHANGELOG.mdwith a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/