Skip to content

fix: support uncompressed FASTQ file formats (.fastq, .fq)#306

Merged
kelly-sovacool merged 10 commits intomainfrom
copilot/update-pipeline-fastq-support
Apr 13, 2026
Merged

fix: support uncompressed FASTQ file formats (.fastq, .fq)#306
kelly-sovacool merged 10 commits intomainfrom
copilot/update-pipeline-fastq-support

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 12, 2026

The samplesheet validator rejected uncompressed FASTQ files from SRA downloads, requiring .fastq.gz or .fq.gz extensions only.

Changes

  • Validation logic (bin/check_samplesheet.py): Extended file extension check to accept .fastq, .fq, .fastq.gz, and .fq.gz
  • Documentation (docs/guide/usage.md): Documented supported file formats in samplesheet specification
# Before
if not fastq.endswith(".fastq.gz") and not fastq.endswith(".fq.gz"):
    print_error("FastQ file does not have extension '.fastq.gz' or '.fq.gz'!")

# After  
if not (
    fastq.endswith(".fastq.gz")
    or fastq.endswith(".fq.gz")
    or fastq.endswith(".fastq")
    or fastq.endswith(".fq")
):
    print_error("FastQ file does not have extension '.fastq.gz', '.fq.gz', '.fastq', or '.fq'!")

Backward compatible - all existing samplesheets with compressed files continue to work.

Original prompt

This section details on the original issue you should resolve

<issue_title>Pipeline fails at samplesheet check if files are not fastq.gz or fq.gz</issue_title>
<issue_description>### Description of the bug

Files downloaded from SRA archive were imported as unpacked .fastq files. CHAMPAGNE failed at samplesheet check. Log indicates failure at

if not fastq.endswith(".fastq.gz") and not fastq.endswith(".fq.gz"):

Appears to require both file as fastq.gz format and matching format name in samplesheet.csv

Command used and terminal output

champagne run --output . --input samplesheet.csv

Relevant files

No response

System information

No response</issue_description>

<agent_instructions>Modify the pipeline to accept input files in .fastq format, rather than requiring they be gzipped.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits February 12, 2026 16:41
Co-authored-by: kelly-sovacool <17768269+kelly-sovacool@users.noreply.github.com>
Co-authored-by: kelly-sovacool <17768269+kelly-sovacool@users.noreply.github.com>
Co-authored-by: kelly-sovacool <17768269+kelly-sovacool@users.noreply.github.com>
Copilot AI changed the title [WIP] Modify pipeline to accept .fastq files in samplesheet check Support uncompressed FASTQ file formats (.fastq, .fq) Feb 12, 2026
Copilot AI requested a review from kelly-sovacool February 12, 2026 16:46
@kelly-sovacool
Copy link
Copy Markdown
Member

testing with

./bin/champagne run -profile test --input ./tests/nxf/samplesheet_test_fastq.csv --mode local --contrasts false

@kelly-sovacool kelly-sovacool marked this pull request as ready for review April 13, 2026 17:57
@kelly-sovacool kelly-sovacool changed the title Support uncompressed FASTQ file formats (.fastq, .fq) fix: support uncompressed FASTQ file formats (.fastq, .fq) Apr 13, 2026
@kelly-sovacool kelly-sovacool merged commit f4ab184 into main Apr 13, 2026
7 checks passed
@kelly-sovacool kelly-sovacool deleted the copilot/update-pipeline-fastq-support branch April 13, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pipeline fails at samplesheet check if files are not fastq.gz or fq.gz

2 participants