muphys: Only write the surface level of the fluxes#995
Open
havogt wants to merge 2 commits intomuphys_bug_fixfrom
Open
muphys: Only write the surface level of the fluxes#995havogt wants to merge 2 commits intomuphys_bug_fixfrom
havogt wants to merge 2 commits intomuphys_bug_fixfrom
Conversation
havogt
commented
Jan 19, 2026
| write_height_field("qg", self.qg) | ||
| if self.pflx is not None: | ||
| write_height_field("pflx", self.pflx) | ||
| write_surface_field("pflx", self.pflx) |
havogt
commented
Jan 19, 2026
| inp, dt=experiment.dt, qnc=experiment.qnc, backend=backend_like | ||
| ) | ||
|
|
||
| graupel_run_program( |
Contributor
Author
There was a problem hiding this comment.
We should also add checks for the fluxes.
havogt
commented
Jan 19, 2026
Comment on lines
606
to
608
| { | ||
| dims.CellDim: (horizontal_start, horizontal_end), | ||
| dims.KDim: (vertical_end - 1, vertical_end), |
Contributor
Author
There was a problem hiding this comment.
this should be a full field, right?
havogt
commented
Jan 19, 2026
| dims.CellDim: (horizontal_start, horizontal_end), | ||
| dims.KDim: (vertical_start, vertical_end), | ||
| }, | ||
| domain=( |
Contributor
Author
There was a problem hiding this comment.
changes should also be applied to full_muphys
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.