Enable gauss3d experiment for distributed tests#1013
Conversation
|
cscs-ci run distributed |
|
cscs-ci run default |
|
cscs-ci run default |
|
@jcanton @edopao FYI I tried to enable testdata download on this PR to get the latest torus data, but CI reports permission denied on the testdata directory: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/5125340235196978/2255149825504669/-/jobs/13036430153#L1904. Should the |
I have added write permission to the user group. I will retrigger the CI now. |
|
cscs-ci run default |
|
cscs-ci run distributed |
Thanks @edopao! Tests work now (failing because of the tests themselves, but the download is successful). |
|
@jcanton @nfarabullini I think this is mostly ok (pending CI coming back online...), but I've marked the tests that require domain_length/height for the torus grid as xfail for now. I'd like to attempt a slightly bigger refactoring of GlobalGridParams/GridShape so we could get the information from there (from In any case, if you don't object I'd prefer to have the current state merged as is (modulo review comments) as it enables the torus grid for most parallel tests. |
|
cscs-ci run default |
|
cscs-ci run distributed |
22eb1cd to
c5bfb61
Compare
|
cscs-ci run default |
|
cscs-ci run distributed |
|
cscs-ci run default |
b7f647b to
a760e3f
Compare
|
cscs-ci run default |
|
cscs-ci run distributed |
…y.py Co-authored-by: Jacopo Canton <jacopo.canton@gmail.com>
…y.py Co-authored-by: Jacopo Canton <jacopo.canton@gmail.com>
…y.py Co-authored-by: Jacopo Canton <jacopo.canton@gmail.com>
…o gauss3d-distributed-tests
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
jcanton
left a comment
There was a problem hiding this comment.
good now, nice to finally have all these tests for torus too!
|
cscs-ci run default |
|
cscs-ci run distributed |
* main: Reject namelist parameters not supported (#1079) Update to gt4py v1.1.6 (#1081) Merge bdy halo stencils (#1066) Enable gauss3d experiment for distributed tests (#1013) Reenable MPS in CI (#1057) Don't compute RBF coefficients over whole domain to avoid non-positive definite matrices (#1077) muphys: Only write the surface level of the fluxes (#995) Update to gt4py v1.1.5 (#1072) Add missing asserts to dallclose calls (#1078) Print test durations in CI (#1058) Fix: Unconditionally exchange at end of corrector (#1074)
* main: Remove `vct_b` bindings only (#1082) Replace `pg_edgeidx_dsl` mask by multiplying with 0.0 (#1053) Replace `mask_hdiff` by multiplying with 0.0 (#1056) fix type hint in DiffusionConfig and remove Literal (#1088) muphys: graupel py2fgen bindings (#1073) Fix mypy warnings for DiffusionConfig (#1086) Add tracer advection to standalone driver [cycle 34] (#1039) Reject namelist parameters not supported (#1079) Update to gt4py v1.1.6 (#1081) Merge bdy halo stencils (#1066) Enable gauss3d experiment for distributed tests (#1013) Reenable MPS in CI (#1057) Don't compute RBF coefficients over whole domain to avoid non-positive definite matrices (#1077) muphys: Only write the surface level of the fluxes (#995) Update to gt4py v1.1.5 (#1072)
Requires #1004 and the gauss3d test data.
Enables the gauss3d experiment as test input for the distributed tests.
xfails a few remaining gauss3d tests that need domain_length/height to do the computation, which is not available in the serialized data.
Also does a small refactoring to the Grid definitions to have the torus grid domain length/height avaiable for tests that don't read grid files. I've also moved the number of cells/vertices/edges to the GlobalGridParams in the Grid definition.