Skip to content

Enable gauss3d experiment for distributed tests#1013

Merged
msimberg merged 24 commits intoC2SM:mainfrom
msimberg:gauss3d-distributed-tests
Feb 26, 2026
Merged

Enable gauss3d experiment for distributed tests#1013
msimberg merged 24 commits intoC2SM:mainfrom
msimberg:gauss3d-distributed-tests

Conversation

@msimberg
Copy link
Copy Markdown
Contributor

@msimberg msimberg commented Jan 28, 2026

Requires #1004 and the gauss3d test data.

Enables the gauss3d experiment as test input for the distributed tests.

xfails a few remaining gauss3d tests that need domain_length/height to do the computation, which is not available in the serialized data.

Also does a small refactoring to the Grid definitions to have the torus grid domain length/height avaiable for tests that don't read grid files. I've also moved the number of cells/vertices/edges to the GlobalGridParams in the Grid definition.

jcanton added a commit that referenced this pull request Jan 30, 2026
@msimberg msimberg changed the title Gauss3d distributed tests Enable gauss3d experiment for distributed tests Feb 6, 2026
@msimberg
Copy link
Copy Markdown
Contributor Author

msimberg commented Feb 6, 2026

cscs-ci run distributed

@msimberg
Copy link
Copy Markdown
Contributor Author

msimberg commented Feb 6, 2026

cscs-ci run default

@msimberg
Copy link
Copy Markdown
Contributor Author

msimberg commented Feb 9, 2026

cscs-ci run default

@msimberg
Copy link
Copy Markdown
Contributor Author

msimberg commented Feb 9, 2026

@jcanton @edopao FYI I tried to enable testdata download on this PR to get the latest torus data, but CI reports permission denied on the testdata directory: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/5125340235196978/2255149825504669/-/jobs/13036430153#L1904. Should the icontest user be given permissions to write to that directory or do we stick to manually updating the data?

@edopao
Copy link
Copy Markdown
Contributor

edopao commented Feb 9, 2026

@jcanton @edopao FYI I tried to enable testdata download on this PR to get the latest torus data, but CI reports permission denied on the testdata directory: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/5125340235196978/2255149825504669/-/jobs/13036430153#L1904. Should the icontest user be given permissions to write to that directory or do we stick to manually updating the data?

I have added write permission to the user group. I will retrigger the CI now.

@edopao
Copy link
Copy Markdown
Contributor

edopao commented Feb 9, 2026

cscs-ci run default

@msimberg
Copy link
Copy Markdown
Contributor Author

msimberg commented Feb 9, 2026

cscs-ci run distributed

@msimberg
Copy link
Copy Markdown
Contributor Author

msimberg commented Feb 9, 2026

@jcanton @edopao FYI I tried to enable testdata download on this PR to get the latest torus data, but CI reports permission denied on the testdata directory: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/5125340235196978/2255149825504669/-/jobs/13036430153#L1904. Should the icontest user be given permissions to write to that directory or do we stick to manually updating the data?

I have added write permission to the user group. I will retrigger the CI now.

Thanks @edopao! Tests work now (failing because of the tests themselves, but the download is successful).

@msimberg msimberg marked this pull request as ready for review February 12, 2026 13:34
@msimberg
Copy link
Copy Markdown
Contributor Author

@jcanton @nfarabullini I think this is mostly ok (pending CI coming back online...), but I've marked the tests that require domain_length/height for the torus grid as xfail for now. I'd like to attempt a slightly bigger refactoring of GlobalGridParams/GridShape so we could get the information from there (from model/testing/definitions.py, i.e. read from grid file even when serialized data). Alternatively, I may just try to add the information to the serialized data.

In any case, if you don't object I'd prefer to have the current state merged as is (modulo review comments) as it enables the torus grid for most parallel tests.

@msimberg
Copy link
Copy Markdown
Contributor Author

cscs-ci run default

@msimberg
Copy link
Copy Markdown
Contributor Author

cscs-ci run distributed

@msimberg msimberg force-pushed the gauss3d-distributed-tests branch from 22eb1cd to c5bfb61 Compare February 12, 2026 14:41
@msimberg
Copy link
Copy Markdown
Contributor Author

cscs-ci run default

@msimberg
Copy link
Copy Markdown
Contributor Author

cscs-ci run distributed

@msimberg
Copy link
Copy Markdown
Contributor Author

cscs-ci run default

Comment thread model/common/tests/common/grid/mpi_tests/test_parallel_geometry.py Outdated
Comment thread model/common/tests/common/grid/mpi_tests/test_parallel_geometry.py Outdated
Comment thread model/common/tests/common/grid/mpi_tests/test_parallel_geometry.py Outdated
@msimberg msimberg force-pushed the gauss3d-distributed-tests branch from b7f647b to a760e3f Compare February 26, 2026 09:15
@msimberg
Copy link
Copy Markdown
Contributor Author

cscs-ci run default

@msimberg
Copy link
Copy Markdown
Contributor Author

cscs-ci run distributed

Comment thread model/driver/src/icon4py/model/driver/initialization_utils.py
Comment thread model/common/tests/common/grid/unit_tests/test_grid_manager.py
@msimberg msimberg requested a review from jcanton February 26, 2026 13:15
Comment thread model/common/tests/common/grid/unit_tests/test_grid_manager.py
Comment thread model/common/tests/common/grid/mpi_tests/test_parallel_geometry.py Outdated
Comment thread model/common/tests/common/grid/mpi_tests/test_parallel_geometry.py
Comment thread model/common/tests/common/grid/mpi_tests/test_parallel_geometry.py
Comment thread model/common/tests/common/interpolation/mpi_tests/test_parallel_interpolation.py Outdated
Comment thread model/common/tests/common/interpolation/mpi_tests/test_parallel_interpolation.py Outdated
msimberg and others added 5 commits February 26, 2026 14:28
…y.py

Co-authored-by: Jacopo Canton <jacopo.canton@gmail.com>
…y.py

Co-authored-by: Jacopo Canton <jacopo.canton@gmail.com>
…y.py

Co-authored-by: Jacopo Canton <jacopo.canton@gmail.com>
@github-actions
Copy link
Copy Markdown

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

Copy link
Copy Markdown
Contributor

@jcanton jcanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good now, nice to finally have all these tests for torus too!

@msimberg
Copy link
Copy Markdown
Contributor Author

cscs-ci run default

@msimberg
Copy link
Copy Markdown
Contributor Author

cscs-ci run distributed

@msimberg msimberg merged commit f6f7892 into C2SM:main Feb 26, 2026
48 checks passed
@msimberg msimberg deleted the gauss3d-distributed-tests branch February 26, 2026 21:40
jcanton added a commit that referenced this pull request Feb 27, 2026
* main:
  Reject namelist parameters not supported (#1079)
  Update to gt4py v1.1.6 (#1081)
  Merge bdy halo stencils (#1066)
  Enable gauss3d experiment for distributed tests (#1013)
  Reenable MPS in CI (#1057)
  Don't compute RBF coefficients over whole domain to avoid non-positive definite matrices (#1077)
  muphys: Only write the surface level of the fluxes (#995)
  Update to gt4py v1.1.5 (#1072)
  Add missing asserts to dallclose calls (#1078)
  Print test durations in CI (#1058)
  Fix: Unconditionally exchange at end of corrector (#1074)
jcanton added a commit that referenced this pull request Mar 3, 2026
* main:
  Remove `vct_b` bindings only (#1082)
  Replace `pg_edgeidx_dsl` mask by multiplying with 0.0 (#1053)
  Replace `mask_hdiff` by multiplying with 0.0 (#1056)
  fix type hint in DiffusionConfig and remove Literal (#1088)
  muphys: graupel py2fgen bindings (#1073)
  Fix mypy warnings for DiffusionConfig (#1086)
  Add tracer advection to standalone driver [cycle 34] (#1039)
  Reject namelist parameters not supported (#1079)
  Update to gt4py v1.1.6 (#1081)
  Merge bdy halo stencils (#1066)
  Enable gauss3d experiment for distributed tests (#1013)
  Reenable MPS in CI (#1057)
  Don't compute RBF coefficients over whole domain to avoid non-positive definite matrices (#1077)
  muphys: Only write the surface level of the fluxes (#995)
  Update to gt4py v1.1.5 (#1072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants