Open
Conversation
added 4 commits
March 26, 2026 21:39
As a consequence ports become compulsory for outputs as well as inputs
it is implemented, use it!
- dynamic-complex: migrate cycles section from old list+port format to new dict format - DYAMOND_aiida: migrate cycles section from old list+port format to new dict format
GeigerJ2
reviewed
Mar 31, 2026
Collaborator
GeigerJ2
left a comment
GeigerJ2
left a comment
There was a problem hiding this comment.
OK, done with a first round of review. Have a bunch of comments, but nothing seems critical / blocking. Will have another round after the first ones are addressed
added 6 commits
April 13, 2026 10:13
added 4 commits
April 20, 2026 15:45
also explicit imports from the typing module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invert order of port and data in config file.
As a consequence ports become compulsory for outputs as well as inputs.