[READY FOR REVIEW] Implement Database-Backed Ingestion Progress Bar#68
Merged
Conversation
Collaborator
Author
|
Against #66 |
Dead-Bytes
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
knowledgeDbabstraction.packages/ingest-github/src/index.tsto usedbProgressContextFactoryby default, keeping public registration signatures clean and localized.reposRoute.tsin the server to fall back tostatus.totalFilesfor reporting thefileCountvalue, ensuring the CLI prints the correct number of files indexed (e.g.17 files) rather than0 filesupon completion.Why
The CLI depends on polling the server's repos REST endpoint to show progress and file counts. However, since the open-source client clones to disk directly and does not write raw file archives to the database,
fileCountreturned0and progress fields stayedundefined(because workers defaulted tonullProgressContextFactory).This PR resolves both issues without requiring any changes to public registration APIs or server-boot configurations.
How to test
bytebell index repo