style(2_find_factorial): Restyle function with typing and extension#10
Open
LesterKim wants to merge 1 commit intoByteAcademyCo:masterfrom
Open
style(2_find_factorial): Restyle function with typing and extension#10LesterKim wants to merge 1 commit intoByteAcademyCo:masterfrom
LesterKim wants to merge 1 commit intoByteAcademyCo:masterfrom
Conversation
LesterKim
commented
Jul 18, 2020
| def factorial_recursive(n): | ||
| return 1 if n is 1 else n * factorial_recursive(n-1) | ||
| def factorial_recursive(integer: int) -> int: | ||
| return 1 if integer is 0 else integer * factorial_recursive(integer - 1) |
Author
There was a problem hiding this comment.
A sleek but more cryptic alternative:
Suggested change
| return 1 if integer is 0 else integer * factorial_recursive(integer - 1) | |
| return int(integer is 0) or integer * factorial_recursive(integer - 1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included zero factorial giving
1and some typing as well as a more descriptive argument name.