Fix issue where command history added to shell was incompatible with fish format, corrupting history#142
Open
mooz wants to merge 1 commit intoBuilderIO:mainfrom
Open
Fix issue where command history added to shell was incompatible with fish format, corrupting history#142mooz wants to merge 1 commit intoBuilderIO:mainfrom
mooz wants to merge 1 commit intoBuilderIO:mainfrom
Conversation
…Fish format, corrupting history
Contributor
|
thanks @mooz - looks like build not passing though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix fish shell history format handling
Problem
The current implementation corrupts the fish shell history file by appending commands in an incorrect format. The fish shell history file uses a YAML-like format rather than simple newline-separated entries.
Solution
Implemented shell-specific handlers to properly read and write to each shell's history file according to its specific format.
Changes
ShellHistoryHandlerinterfaceSimpleHistoryHandlerclass for basic shells (bash, sh, ksh, tcsh)ZshHistoryHandlerclass for zsh (handling timestamp format)FishHistoryHandlerclass for fish (handling YAML-like format)Testing