Skip to content

iPhone X safe area update #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctayl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

iPhone X safe area update #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"description": "\"social-plugin\"",
"scripts": {
"postinstall": "./node_modules/.bin/bower install",
"test": "./node_modules/.bin/karma start --single-run --browsers PhantomJS"
"test": "./node_modules/.bin/karma start --single-run --browsers PhantomJS",
"build": "cd .. && rm -rf socialPlugin.zip && zip -r socialPlugin.zip socialPlugin/ -x *.git* *node_modules/*"
},
"keywords": [
"angularjs",
Expand Down
31 changes: 31 additions & 0 deletions widget/assets/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@
z-index: 11;
}


.holder.bottom-post hr {
margin: 0;
}
Expand Down Expand Up @@ -460,6 +461,7 @@
position: relative;
}


.play-btn:after {
content: "\e612";
font-family: 'icomoon';
Expand Down Expand Up @@ -801,4 +803,33 @@ textarea {
margin-left: 10px;
font-size: 17px;
vertical-align: 3px;
}

.thread-container {
height: calc(100% - 47px);
padding-top: 15px !important;
overflow-y: auto;
overflow-x: hidden;
}


html[safe-area="true"] .holder.bottom-post:not(.full-post-section) {
height: calc(43px + env(safe-area-inset-bottom)) !important;
height: calc(43px + constant(safe-area-inset-bottom)) !important;
}
html[safe-area="true"] .has-comment-box {
height: 100% !important;
padding-bottom: calc(39px + env(safe-area-inset-bottom)) !important;
padding-bottom: calc(39px + constant(safe-area-inset-bottom)) !important;
}

html[safe-area="true"] .full-post-section .full-post-box .media-section {
padding-bottom: env(safe-area-inset-bottom) !important;
padding-bottom: constant(safe-area-inset-bottom) !important;
}

html[safe-area="true"] .social-plugin .social-thread {
height: 100% !important;
display: flex;
flex-direction: column;
}
2 changes: 1 addition & 1 deletion widget/templates/thread.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div class="padded head-btn text-center padding-bottom-ten">
<a ng-click="Thread.followUnfollow(Thread.getFollowingStatus())">{{Thread.getFollowingStatus()}}</a>
</div>
<div style="height: calc(100% - 47px); padding-top: 15px !important; overflow-y: auto;overflow-x: hidden;">
<div class="thread-container">
Copy link
Contributor Author

@ctayl ctayl Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved inline css to stylesheet

<div class="social-item clearfix">
<hr class="small">
<div class="head row clearfix padding-left-ten padding-right-ten margin-bottom-fifteen">
Expand Down