Skip to content

Menu side bar for Challenges#352

Open
phipsae wants to merge 5 commits intomainfrom
menu-side-bar
Open

Menu side bar for Challenges#352
phipsae wants to merge 5 commits intomainfrom
menu-side-bar

Conversation

@phipsae
Copy link
Contributor

@phipsae phipsae commented Jan 7, 2026

Hi,

To make the challenges easier to navigate, I added a sidebar for moving between the different checkpoints (your idea @carletex). It’s definitely not perfect yet, so let me know what you think and what could be improved.

I also had to make a small change to tsconfig.json to fix a TypeScript issue.

Hope thats okay :)

Screenshot 2026-01-07 at 12 19 26 Screenshot 2026-01-07 at 12 19 59 Screenshot 2026-01-07 at 12 19 52

@phipsae phipsae requested review from carletex and rin-st January 7, 2026 17:22
@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
speedrunethereum-v2 Ready Ready Preview, Comment Jan 22, 2026 9:04pm

Request Review

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @phipsae !

Some comments

Maybe add some hover bg for menu items on the desktop?

Close button position is wrong on mobiles

Image

Also for both mobiles and desktop there's empty space on the top of menu. Can we fix it when there's no header at the top?

Image
  • When you click on the item which is above your current position, it works wrong: I click at checkpoint 2 but scrolled to checkpoint 3.
  • When I click checkpoint 7 it becomes active and then others becomes active when scrolling to 7. Not sure we want to highlight intermediate positions. But if we show intermediates, I think we don't need to highlight destination checkpoint first.
  • nit: when checkpoint in the menu is highlighted, text becomes bold and height of the menu item could change. Not sure how to fix it though, maybe just use border (full? only left? only bottom?) and don't change font-weight
Screen.Recording.2026-01-14.at.17.42.49.mov

@phipsae
Copy link
Contributor Author

phipsae commented Jan 20, 2026

Hi Rinat,
Thanks a lot for reviewing the PR and for pointing out the issues. I addressed all of your requests.
Regarding the screen recording, I could not fully understand what is happening since the left side is cut off.

@phipsae phipsae requested a review from rin-st January 20, 2026 22:10
@rin-st
Copy link
Member

rin-st commented Jan 21, 2026

Much better!

Two additional nitpicks:
Can we remove this space for mobiles?
Screenshot 2026-01-21 at 17 02 52

Could you center the button and move it a bit to the left on mobiles when width is less than sm: (<640px) ?
Screenshot 2026-01-21 at 17 03 40

@phipsae
Copy link
Contributor Author

phipsae commented Jan 22, 2026

Moved the hamburger menu button into the Header component so it stays aligned with the logo. There I added a context to share the sidebar state between Header and ChallengeSidebar. Also adjusted the sidebar padding so content starts now at the top.

Let me know what you think @rin-st

@phipsae
Copy link
Contributor Author

phipsae commented Feb 4, 2026

@rin-st quick reminder :) Are we merging this, or is anything still missing?

@rin-st
Copy link
Member

rin-st commented Feb 4, 2026

For me, it's looking good! But I want @carletex to review PR too, so waiting for him

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants