Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rin-st
left a comment
There was a problem hiding this comment.
Thanks for the PR @phipsae !
Some comments
Maybe add some hover bg for menu items on the desktop?
Close button position is wrong on mobiles
Also for both mobiles and desktop there's empty space on the top of menu. Can we fix it when there's no header at the top?
- When you click on the item which is above your current position, it works wrong: I click at checkpoint 2 but scrolled to checkpoint 3.
- When I click checkpoint 7 it becomes active and then others becomes active when scrolling to 7. Not sure we want to highlight intermediate positions. But if we show intermediates, I think we don't need to highlight destination checkpoint first.
- nit: when checkpoint in the menu is highlighted, text becomes bold and height of the menu item could change. Not sure how to fix it though, maybe just use border (full? only left? only bottom?) and don't change font-weight
Screen.Recording.2026-01-14.at.17.42.49.mov
|
Hi Rinat, |
|
Moved the hamburger menu button into the Header component so it stays aligned with the logo. There I added a context to share the sidebar state between Header and ChallengeSidebar. Also adjusted the sidebar padding so content starts now at the top. Let me know what you think @rin-st |
|
@rin-st quick reminder :) Are we merging this, or is anything still missing? |
|
For me, it's looking good! But I want @carletex to review PR too, so waiting for him |


Hi,
To make the challenges easier to navigate, I added a sidebar for moving between the different checkpoints (your idea @carletex). It’s definitely not perfect yet, so let me know what you think and what could be improved.
I also had to make a small change to tsconfig.json to fix a TypeScript issue.
Hope thats okay :)