ci: publish helm chart to GHCR#1
Conversation
Adds a release workflow that packages the firecrawl-helm chart and pushes it as an OCI artifact to GHCR on Chart.yaml version bumps, plus a lint workflow that runs on PRs touching the chart. README now documents the public GHCR install path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates the Helm chart documentation to include instructions for installing from the GitHub Container Registry (GHCR) and adds steps for pulling and inspecting the chart locally. The review feedback highlights that the updated installation command is missing necessary configuration flags for values files and that the manual push example should be updated to use the new registry path for consistency.
| helm upgrade --install firecrawl oci://ghcr.io/budecosystem/charts/firecrawl \ | ||
| --version 0.2.0 \ | ||
| -n firecrawl --create-namespace |
There was a problem hiding this comment.
The installation command is missing the -f values.yaml and -f overlays/prod/values.yaml flags that were present in the previous version. Since the chart's default values.yaml contains several empty placeholders for critical configuration (e.g., API keys, database URLs), the installation will likely fail or be non-functional without providing these configuration files.
| helm upgrade --install firecrawl oci://ghcr.io/budecosystem/charts/firecrawl \ | |
| --version 0.2.0 \ | |
| -n firecrawl --create-namespace | |
| helm upgrade --install firecrawl oci://ghcr.io/budecosystem/charts/firecrawl \ | |
| --version 0.2.0 \ | |
| -n firecrawl --create-namespace \ | |
| -f values.yaml \ | |
| -f overlays/prod/values.yaml |
|
|
||
| ```bash | ||
| HELM_NO_PLUGINS=1 helm package . --destination /tmp/helm-packages | ||
| HELM_NO_PLUGINS=1 helm push /tmp/helm-packages/firecrawl-0.2.0.tgz oci://registry-1.docker.io/winkkgmbh |
There was a problem hiding this comment.
The manual push example still references the old registry oci://registry-1.docker.io/winkkgmbh. It should be updated to use the new GHCR registry path (oci://ghcr.io/budecosystem/charts) to maintain consistency with the rest of the documentation and the new CI workflow.
| HELM_NO_PLUGINS=1 helm push /tmp/helm-packages/firecrawl-0.2.0.tgz oci://registry-1.docker.io/winkkgmbh | |
| HELM_NO_PLUGINS=1 helm push /tmp/helm-packages/firecrawl-0.2.0.tgz oci://ghcr.io/budecosystem/charts |
Addresses PR review: quick-start vs recommended install paths (the latter uses `-f my-values.yaml` derived from `helm show values` since users installing from OCI don't have overlays/prod/values.yaml locally). Replaces the winkkgmbh example with a generic registry placeholder. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
examples/kubernetes/firecrawl-helmand pushes it as an OCI artifact toghcr.io/budecosystem/charts/firecrawlon everyChart.yamlversion bump (also supports manual dispatch with an optional version override).helm lint+helm template(base values and prod overlay) on PRs touching the chart.Notes
mainwill publish version0.2.0and create the GHCR package.charts/firecrawlto Public so anonymoushelm pullworks. Subsequent versions inherit the visibility.Test plan
mainand confirmRelease Helm Chartworkflow completes successfully.helm pull oci://ghcr.io/budecosystem/charts/firecrawl --version 0.2.0succeeds without auth.helm upgrade --install firecrawl oci://ghcr.io/budecosystem/charts/firecrawl --version 0.2.0 -n firecrawl --create-namespacerenders and installs.Lint Helm Chartruns.🤖 Generated with Claude Code