Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Improved CI/CD workflow, increased test coverage for PubSub and MemoryStore components, and resolved linting issues including error checking and deprecation warnings. Updated CI to Go 1.24.


PR created automatically by Jules for task 17961491077411346294 started by @BryceWayne

- Enhance `.github/workflows/go.yml` to use Go 1.24, run race detector, upload coverage, and run `golangci-lint`.
- Add `memorystore/pubsub_memory_test.go` and `memorystore/memorystore_extra_test.go` to improve coverage of edge cases and fallback logic.
- Update `memorystore_test.go` and `pubsub_test.go` to check errors in `defer` statements and other calls, satisfying `errcheck`.
- Suppress deprecation warning for `cloud.google.com/go/pubsub` v1 usage in `memorystore/pubsub_gcp.go` as v2 migration is out of scope.
- Fix minor lint issues (unused variables, unchecked errors) across the codebase.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@BryceWayne
Copy link
Owner

The ci cd failed

@BryceWayne BryceWayne self-assigned this Jan 5, 2026
- Enhance `.github/workflows/go.yml` to use Go 1.24, run race detector, upload coverage, and run `golangci-lint` and `gofmt`.
- Add `memorystore/pubsub_memory_test.go` and `memorystore/memorystore_extra_test.go` to improve coverage of edge cases and fallback logic.
- Update `memorystore_test.go` and `pubsub_test.go` to check errors in `defer` statements and other calls, satisfying `errcheck`.
- Suppress deprecation warning for `cloud.google.com/go/pubsub` v1 usage in `memorystore/pubsub_gcp.go` as v2 migration is out of scope.
- Fix minor lint issues (unused variables, unchecked errors) across the codebase.
- Ensure all Go files are formatted with `gofmt`.
@BryceWayne
Copy link
Owner

Screenshot_20260104-222138 There is an issue with ci cd

@google-labs-jules
Copy link
Contributor Author

Screenshot_20260104-222138 There is an issue with ci cd

I have updated the CI workflow to use golangci-lint v1.64.6. This resolves the sync/atomic import error caused by the older linter version being incompatible with Go 1.24 export data.

- Enhance `.github/workflows/go.yml` to use Go 1.24, run race detector, upload coverage, and run `golangci-lint` (v1.64.6) and `gofmt`.
- Add `memorystore/pubsub_memory_test.go` and `memorystore/memorystore_extra_test.go` to improve coverage of edge cases and fallback logic.
- Update `memorystore_test.go` and `pubsub_test.go` to check errors in `defer` statements and other calls, satisfying `errcheck`.
- Suppress deprecation warning for `cloud.google.com/go/pubsub` v1 usage in `memorystore/pubsub_gcp.go`.
- Fix minor lint issues and remove conversational comments from tests.
@BryceWayne BryceWayne marked this pull request as ready for review January 5, 2026 04:31
@BryceWayne BryceWayne merged commit 064026d into root Jan 5, 2026
1 check passed
@BryceWayne BryceWayne deleted the improve-ci-and-tests-17961491077411346294 branch January 5, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants