Feature/metrics and batch ops 8871551962453094290 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracted `PubSubClient` interface to decouple implementation from store logic. - Implemented `GCPPubSub` using `cloud.google.com/go/pubsub`. - Renamed existing in-memory implementation to `InMemoryPubSub` and updated to match interface. - Updated `NewMemoryStore` to automatically use GCP PubSub if `GOOGLE_CLOUD_PROJECT` env var is set. - Added `NewMemoryStoreWithConfig` for explicit configuration. - Updated `main.go` and `README.md` to demonstrate GCP PubSub usage and new features.
Rebased on latest main which includes sharding support. - Extracted `PubSubClient` interface. - Added `GCPPubSub` implementation. - Renamed and updated `InMemoryPubSub`. - Updated `MemoryStore` to use interface and support configuration. - Resolved conflicts with sharded storage implementation.
Rebased feature branch on latest root which includes Sharding support. Integrated PubSub interface and GCP implementation with the sharded MemoryStore. Resolved conflicts in memorystore.go. Verified all tests pass.
Rebased feature branch on latest root which includes Sharding support. - Extracted `PubSubClient` interface. - Added `GCPPubSub` implementation. - Renamed and updated `InMemoryPubSub`. - Updated `MemoryStore` to use interface and support configuration. - Resolved conflicts with sharded storage implementation. - Consolidated commits to clean up history.
Owner
Author
|
@copilot please fix the conflicts |
Contributor
|
@BryceWayne I've opened a new pull request, #13, to work on those changes. Once the pull request is ready, I'll request review from you. |
- Kept agnostic PubSub interface (In-Memory & GCP support) - Preserved batch operations and metrics features - Maintained comprehensive documentation - Merged improved documentation structure from root
Resolve merge conflicts between feature and root branches
Owner
Author
|
@copilot what's up with the error. Fix it |
Contributor
|
@BryceWayne I've opened a new pull request, #14, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: BryceWayne <35088752+BryceWayne@users.noreply.github.com>
Fix CI build step to compile instead of execute
BryceWayne
deleted the
feature/metrics-and-batch-ops-8871551962453094290
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.