Skip to content

PA collection#386

Merged
sdigiulio merged 94 commits intoBrown-University-Library:masterfrom
dpironi:master
Feb 25, 2026
Merged

PA collection#386
sdigiulio merged 94 commits intoBrown-University-Library:masterfrom
dpironi:master

Conversation

@dpironi
Copy link
Copy Markdown
Collaborator

@dpironi dpironi commented Jan 9, 2026

No description provided.

Copy link
Copy Markdown
Collaborator

@sdigiulio sdigiulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Range of fixes need to be made throughout (I've already made some of the changes myself, but I did not identify every instance if there was a pattern of common errors):

  1. Remember to include yourself for authorship purposes.
  2. Every line of a transcription needs to start with an <lb> element with an @n attribute indicating the line number, even if it's a one-line inscription.
  3. The capitalization and punctuation of different sections of the files need to be addressed. Remember that for most short metadata descriptions, the preference is no capitalization (except for proper nouns or adjectives derived from proper nouns) and no punctuation. For commentary and translation, follow standard rules of capitalization/punctuation.
  4. One could add further semantic markup to the transcriptions (e.g. marking up names and the like), though that would be an enhancement rather than a requisite.


<titleStmt>
<title>PA.Phil.UP.UM.A.B8903</title>
<author>Author</author>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to include yourself on the author line when you are the initial author of a file.

<!-- arc, grc, he, lat, und (unknown), zxx (non-linguistic content) -->
<msItem class="#funerary.other">
<!-- short summary of the content of an inscription -->
<p>Relief with male servant and Palmyrene inscription.</p>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not capitalize beginnings of free text descriptions, and do not include periods at the end of single sentences as here.

Comment thread xml_inscriptions/metadata_only/PA.Phil.UP.UM.A.B8904.xml Outdated
Comment thread xml_inscriptions/metadata_only/PA.Phil.UP.UM.A.B8904.xml Outdated
Comment thread xml_inscriptions/metadata_only/PA.Phil.UP.UM.A.B8904.xml Outdated
Comment thread xml_inscriptions/transcribed/PA.Phil.UP.UM.L.MS4012.xml Outdated
Comment thread xml_inscriptions/transcribed/PA.Phil.UP.UM.L.MS2374.xml Outdated
Comment thread xml_inscriptions/transcribed/PA.Phil.UP.UM.L.MS2374.xml Outdated
Comment thread xml_inscriptions/transcribed/PA.Phil.UP.UM.L.L-1033-61.xml Outdated
Comment thread xml_inscriptions/transcribed/PA.Phil.UP.UM.L.L-1033-59.xml Outdated
@dpironi dpironi requested a review from sdigiulio February 24, 2026 01:03
Copy link
Copy Markdown
Collaborator

@sdigiulio sdigiulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of small fixes still need to be made throughout; however, pretty much everything is in good shape here, and I'll merge these into the main. Remember to go back and address the various comments/small corrections.

<origin>
<date evidence="#archaeology" notBefore="0301" notAfter="1101">300-1100
CE</date>
<placeName ref="asia.near_east">Beth Shean, Israel</placeName>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check the hierarchical ordering of the placename

<listBibl>
<bibl>
<ptr type="rest-of-bibl" target="#Beazley_2"/>
<biblScope unit="page">p. 318</biblScope>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory you don't need the "p." since it's marked up accordingly

<origin>
<date evidence="#archaeology" notBefore="0074" notAfter="0151">Late
first-early second century CE</date>
<placeName ref="europe.italy">Detailed place name</placeName>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something for the place name to display, other than the default value? Even if it's just Italy, that's better than leaving the default

</titleStmt>
<publicationStmt>
<authority>Brown University</authority>
<idno type="USEpigraphy" xml:id="PA.Phil.UP.UM.L.L-1033-11"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something wonky with the display field of the idNo

</titleStmt>
<publicationStmt>
<authority>Brown University</authority>
<idno type="USEpigraphy" xml:id="PA.Phil.UP.UM.L.L-1033-22">Repeat USEP ID</idno>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing idno display (make sure to go back and double-check these throughout...).

<bibl>
<ptr type="rest-of-bibl" target="#CAT_3"/>
<biblScope unit="item">408</biblScope>
<biblScope unit="item">p. 408</biblScope>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the @unit if you're changing it in the text. (But also, you don't need to include p., no., etc. unless there are multiple different kinds of units being included.

<bibl>
<ptr type="rest-of-bibl" target="#IG_II2"/>
<biblScope unit="item">11012</biblScope>
<biblScope unit="item">no. 11012</biblScope>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the no. here -- that is already captured in the @unit. With it included, this would render as IG II2: no. 11012.

<titleStmt>
<title>PA.Phil.UP.UM.L.80-2-15</title>
<author>Author</author>
<author>Davide Pironi</author>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbodel How should we handle authorship for this file?

<body>
<div type="edition">
<ab>
<lb n="1"/>Δίφιλος
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name markup

</titleStmt>
<publicationStmt>
<authority>Brown University</authority>
<idno type="USEpigraphy" xml:id="PA.Phil.UP.UM.G.MS5463">Repeat USEP ID</idno>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID

@sdigiulio sdigiulio merged commit 1f883bb into Brown-University-Library:master Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants