Skip to content

Ecollazos/gaud 8697 slot not center aligning#6661

Merged
EdwinACL831 merged 9 commits intomainfrom
ecollazos/GAUD-8697_slot_not_left_aligning
Mar 9, 2026
Merged

Ecollazos/gaud 8697 slot not center aligning#6661
EdwinACL831 merged 9 commits intomainfrom
ecollazos/GAUD-8697_slot_not_left_aligning

Conversation

@EdwinACL831
Copy link
Contributor

@EdwinACL831 EdwinACL831 commented Mar 5, 2026

This addresses the issue described in GAUD-8697 where the badge slot is not being centered when the align-center attribute is true for the component.

The solution proposed was to add a new CSS rule to center the badge when the card has the align-center html attribute

Edwin Collazos added 2 commits March 5, 2026 09:13
Added a new CSS rule to make the badge slot to be left aligned when the
align-center attribute is true for the card component
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-6661/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

@EdwinACL831 EdwinACL831 marked this pull request as ready for review March 5, 2026 21:19
@EdwinACL831 EdwinACL831 requested a review from a team as a code owner March 5, 2026 21:19
Copy link
Contributor

@GZolla GZolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tangentially related to this change, the demo for card badges seems broken apparently the stick figure image we were using is not loading, not sure if removed or if wikimedias api changed. Feels like a small separate ticket though

@dbatiste
Copy link
Contributor

dbatiste commented Mar 6, 2026

As per offline discussion earlier, we're going to wrap this change in a flag, which will require a slight change to this code to check.

@dbatiste
Copy link
Contributor

dbatiste commented Mar 9, 2026

Looks like style linting failed - the linter probably isn't smart enough to realize what's being done here.

@EdwinACL831 EdwinACL831 merged commit 7ab76bc into main Mar 9, 2026
7 checks passed
@EdwinACL831 EdwinACL831 deleted the ecollazos/GAUD-8697_slot_not_left_aligning branch March 9, 2026 19:46
@d2l-github-release-tokens
Copy link

🎉 This PR is included in version 3.221.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants