Develop 047#29
Open
paa93 wants to merge 6 commits intoBrightGamePanel:develop-047from
404rq:develop-047
Open
Conversation
Validate the connection to the screen session, if it fails we simply kill the page and return to home instead of giving the user full shell access to whatever user is logged in over ssh.
This will kill the SSH shell if it fails to connect to screen
This will kill the SSH shell if it fails to connect to screen
This is a critical vulnerability, assume a user enter this: '"; rm -rf #' and bam, the entire file system for the ssh user is deleted. If it's root then the entire server is removed.
Simply sending a command like: "; mkdir hello_world # into rcon tool could bypass the screen and create a folder in the shell if shell commands aren't escaped properly.
php mysql is deprecated and needs to be replaced in order to work in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical security patch, when the panel fails to connect to a running screen session (i.e if a game server crashed) this will kill the page and go back to home rather than giving the user full access to the bash shell.