BI-2860: Made changes to the end point to limit the access.#518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JIRA story card link: BI-2860
This PR updates the experiment dataset creation permission so that
POST /programs/{programId}/experiments/{experimentId}/datasetis restricted toProgram Administrator.Previously, an
Experimental Collaboratorcould reach a flow in the UI that suggested sub-entity dataset creation was available. This change enforces the backend permission rule so collaborator users cannot create sub-entity datasets directly through the API.This PR also adds test coverage for the forbidden collaborator case.
And it depends on the bug/BI-2860-v1.3 for the frontend.
Dependencies
bi-web: bug/BI-2860-v1.3
bi-api: bug/BI-2860-v1.3
Testing
403 Forbiddenon:POST /programs/{programId}/experiments/{experimentId}/datasetManual validation:
bi-webPRChecklist: