Skip to content

BI-2839 - Submission-Scoped Genotype Upload API#515

Merged
HMS17 merged 4 commits into
developfrom
feature/BI-2839
May 12, 2026
Merged

BI-2839 - Submission-Scoped Genotype Upload API#515
HMS17 merged 4 commits into
developfrom
feature/BI-2839

Conversation

@nickpalladino
Copy link
Copy Markdown
Member

@nickpalladino nickpalladino commented May 1, 2026

Description

Story: BI-2839, BI-2840

  • Changed genotype upload container from experiment to sample submission
  • Updated tests, one will need to be re-enabled in BI-2841

Dependencies

  • No dependencies if doing api level testing
  • bi-web feature/2843 if doing end to end testing with updated UI (not required for this PR to pass)

Testing

See acceptance criteria in BI-2839 and BI-2840. Test files are available as attachments in the jira cards.

For api level testing I use insomnia but could do in any of the tools, here is my config:

image
  • POST http://localhost:8081/v1/programs/42ba4e17-02a1-4397-ba72-43d0b9175b85/submissions/049e710e-ee89-4da2-a1e8-35c0bf2e9561/geno/import with appropriate bi-api port, program, and submission ids
  • Setup a Multipart body with file in the name field and the vcf file in the value field
  • Have a valid phylo-token cookie configured

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

@nickpalladino nickpalladino marked this pull request as ready for review May 5, 2026 21:22
@nickpalladino nickpalladino requested review from a team and HMS17 and removed request for a team May 7, 2026 18:03
Copy link
Copy Markdown
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes local UI and api tests for both BI-2839 and BI-2840 acceptance criteria

@HMS17 HMS17 merged commit ad04f83 into develop May 12, 2026
16 checks passed
@HMS17 HMS17 deleted the feature/BI-2839 branch May 12, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants