Skip to content

BI-2820 Improve sample submission tabular error message #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
humsika merged 3 commits into from
May 1, 2026
Merged

BI-2820 Improve sample submission tabular error message #514

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0e65f4
[BI-2820] modified error message
Apr 28, 2026
fe913ec
[BI-2820] remove commented-out code
Apr 30, 2026
441f3cf
Merge branch 'develop' into feature/BI-2820
humsika May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...va/org/breedinginsight/brapps/importer/services/processors/SampleSubmissionProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public class SampleSubmissionProcessor implements Processor {
private static final String UNKNOWN_GID = "Unknown germplasm GID";
private static final String INVALID_COLUMN = "Column must be a number between 1 and 12";
private static final String INVALID_ROW = "Row must be a letter between A and H";
private static final String MULTIPLE_SAMPLES_SINGLE_WELL = "The sample in row %d is already in row: %s, column: %d";
private static final String MULTIPLE_SAMPLES_SINGLE_WELL = "Plate position not unique, duplicate in row %d";
private final String referenceSource;
private final BrAPIGermplasmDAO germplasmDAO;
private final BrAPIObservationUnitDAO observationUnitDAO;
Expand Down Expand Up @@ -230,7 +230,7 @@ private boolean validRow(SampleSubmissionImport row, int rowNum, ValidationError
if (plateLayout[plateRow][plateCol] > 0) {
validationErrors.addError(rowNum,
new ValidationError(SampleSubmissionImport.Columns.ROW + "/" + SampleSubmissionImport.Columns.COLUMN,
String.format(MULTIPLE_SAMPLES_SINGLE_WELL, plateLayout[plateRow][plateCol], Character.toString('A' + plateRow), plateCol),
String.format(MULTIPLE_SAMPLES_SINGLE_WELL, plateLayout[plateRow][plateCol]),
HttpStatus.UNPROCESSABLE_ENTITY));
} else {
plateLayout[plateRow][plateCol] = rowNum;
Expand Down
Loading