Skip to content

[BI-2823] Remove sub entity level name from level relationships in sub entity dataset creation #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jloux-brapi merged 1 commit into from
Apr 15, 2026
Merged

[BI-2823] Remove sub entity level name from level relationships in sub entity dataset creation #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/org/breedinginsight/brapi/v2/services/BrAPITrialService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,8 +618,6 @@ public BrAPIObservationUnit createSubObservationUnit(

// ObservationLevelRelationships.
List<BrAPIObservationUnitLevelRelationship> levelRelationships = new ArrayList<>();
// TODO: Figure out if we actually need to add the sub entity level to the level relationships BI-2823
levelRelationships.add(level);
// ObservationLevelRelationships for rep.
BrAPIObservationUnitLevelRelationship expRepLevel = expUnit.getObservationUnitPosition()
.getObservationLevelRelationships().stream()
Expand Down
Loading