Skip to content

BI-2783 - Logic In Germplasm Import Dependent on Name Lookup #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HMS17 merged 1 commit into from
Apr 13, 2026
Merged

BI-2783 - Logic In Germplasm Import Dependent on Name Lookup #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...org/breedinginsight/brapps/importer/services/processors/germplasm/GermplasmProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,8 @@ public void getExistingBrapiData(List<BrAPIImport> importRows, Program program)
}
}

// Get existing germplasm names
// Get existing germplasm names. This should be used ONLY to identify duplicate germplasm names.
// In general you should look up germplasm by GID.
List<BrAPIGermplasm> dbGermplasm = brAPIGermplasmService.getGermplasmByDisplayName(new ArrayList<>(fileGermplasmByName.keySet()), program.getId());
dbGermplasm.forEach(germplasm -> {
dbGermplasmByName.put(germplasm.getDefaultDisplayName(), germplasm);
Expand Down
Loading