Skip to content

[BI-2813] Set levelNameDbIds in OUs in experiment creation use case#507

Merged
nickpalladino merged 2 commits into
developfrom
feature/BI-2813
Apr 7, 2026
Merged

[BI-2813] Set levelNameDbIds in OUs in experiment creation use case#507
nickpalladino merged 2 commits into
developfrom
feature/BI-2813

Conversation

@jloux-brapi
Copy link
Copy Markdown
Collaborator

@jloux-brapi jloux-brapi commented Apr 2, 2026

Description

Story: BI-2813

  • Updated observation level creation logic in the create experiment workflow to work similarly and use similar methods as sub entity workflow
  • Added some comments to CommitPendingImportObjectsStep regarding how it could be improved to reflect the actual use case it runs, and some deterministic logic which is needed to support the observation level creation logic supporting that use case.

Dependencies

BI-2814 should be merged first, and then this ticket/MR should be pointed to develop

Testing

Create a program then do the following:

  • Create a new experiment with any level name
  • Create a sub-entity dataset with any level name (except top level name of this experiment, this will always result in an error as intended)
  • Verify no errors occur on creating the datasets, and that the data can be viewed for the datasets in the experiment, and the dataset data can also be exported without issue

In a program where there already exists an experiment with both a top level dataset and a sub entity dataset:

  • Create a new experiment with top level name that has the same name as the existing sub entity dataset name created in the first experiment
  • Create a sub-entity dataset that has the same name as an existing top level dataset in a different experiment in the program.
  • Verify no errors occur on creating the datasets, and that the data can be viewed for the datasets in the experiment, and the dataset data can also be exported without issue

In a program where there already exists an experiment with both a top level dataset and a sub entity dataset:

  • Create a new experiment with top level name that has the same name as the existing sub entity dataset name created in the first experiment
  • Create a sub-entity dataset with a name that isn’t shared by any of the other existing sub entity datasets for the experiments in this program.
  • Verify no errors occur on creating the datasets, and that the data can be viewed for the datasets in the experiment, and the dataset data can also be exported without issue

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

Base automatically changed from feature/BI-2814 to develop April 7, 2026 13:10
Copy link
Copy Markdown
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing looked good

@nickpalladino nickpalladino merged commit b4f02f3 into develop Apr 7, 2026
1 check passed
@nickpalladino nickpalladino deleted the feature/BI-2813 branch April 7, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants