-
Notifications
You must be signed in to change notification settings - Fork 3
Added parentage functions #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
josuechinchilla
wants to merge
13
commits into
development
Choose a base branch
from
add_parentage_functions
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f590dad
Merge pull request #58 from Breeding-Insight/development
josuechinchilla 20d2764
corrected importFrom statement in parentage functions and ped_check
f2d3f40
updated NAMESPACE to reflect updated importFrom statements
c1fe543
Update R/check_ped.R
josuechinchilla 0a13483
updated error handling and reporting for check_ped, Also major improv…
9bbc507
updated error handling and reporting for check_ped
f798362
updated parentage functions to work allow user to display NA or not, …
03725d8
Made edits suggested by autopilot
506a47f
added edits suggested by copilot
977e070
modified default params
5db5fa2
Added authors fror functions and made headers concise
6b84e18
staged comments for next push
4eb79bb
removed zip option and added specific correction arguments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,3 +10,5 @@ | |
| ^package-code\.Rmd$ | ||
| ^docs$ | ||
| ^CRAN-SUBMISSION$ | ||
| ^\.positai$ | ||
| ^\.claude$ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,4 @@ | |
| .Ruserdata | ||
| revdep/ | ||
| .DS_Store | ||
| .positai | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
janitorwas removed from the NAMESPACE imports, and there are no remaining references in the R code. The package still listsjanitorunder Imports in DESCRIPTION, which will keep it as a hard dependency unnecessarily. Consider removing it from DESCRIPTION (or re-adding the NAMESPACE import if it's still intended to be required).