Skip to content

add invisibility #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Alessandro-Barbieri wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

add invisibility #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a1753f6
wip
Alessandro-Barbieri Mar 2, 2026
10e06c4
unused variable
Alessandro-Barbieri Mar 2, 2026
cbf8b26
spaces
Alessandro-Barbieri Mar 2, 2026
a12556c
wip
Alessandro-Barbieri Mar 4, 2026
d1bf2c6
remove unused
Alessandro-Barbieri Mar 4, 2026
f77a554
Merge branch 'BreakBB:master' into invisibility
Alessandro-Barbieri Mar 4, 2026
d933efb
wip
Alessandro-Barbieri Mar 4, 2026
edcec90
sort
Alessandro-Barbieri Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions Modules/Config/GeneralSection.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,32 @@ function _Config:LoadGeneralSection()
Stats.RebuildStatInfos()
end,
},
stealth = {
type = "toggle",
order = 2,
name = function() return i18n("Show stealth") end,
desc = function() return i18n("Shows/Hides the stealth value.") end,
width = 1.5,
disabled = function() return (not ExtendedCharacterStats.profile.general.display); end,
get = function () return ExtendedCharacterStats.profile.general.stealth.display; end,
set = function (_, value)
ExtendedCharacterStats.profile.general.stealth.display = value
Stats.RebuildStatInfos()
end,
},
invisibility = {
type = "toggle",
order = 3,
name = function() return i18n("Show invisibility") end,
desc = function() return i18n("Shows/Hides the invisibility value.") end,
width = 1.5,
disabled = function() return (not ExtendedCharacterStats.profile.general.display); end,
get = function () return ExtendedCharacterStats.profile.general.invisibility.display; end,
set = function (_, value)
ExtendedCharacterStats.profile.general.invisibility.display = value
Stats.RebuildStatInfos()
end,
},
},
}
end
264 changes: 264 additions & 0 deletions Modules/Data/Constants.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
local IsClassic = ECS.IsClassic
local IsTBC = ECS.IsTBC
local IsWotlk = ECS.IsWotlk

---@class Data
local Data = ECSLoader:ImportModule("Data")

Expand All @@ -20,6 +24,7 @@ Data.MAGE = 8
Data.WARLOCK = 9
Data.DRUID = 11

--- auras with attributes "Passive spell" or "Aura is hidden" should not be listed here
Data.Aura = {
AllowCastingManaRegeneration = {
[6117] = (ECS.IsWotlk and 0.5 or 0.3), -- Mage Armor rank 1
Expand Down Expand Up @@ -79,6 +84,153 @@ Data.Aura = {
[17800] = (ECS.IsWotlk and -5 or nil), -- Shadow Mastery 5/5
[22959] = (ECS.IsWotlk and -5 or nil), -- Improved Scorch
},
--- index 0 is for "Apply Aura: Invisibility"
--- index n is for "Apply Aura: Invisibility (n)"
Invisibility = {
[0] = {
[66] = IsClassic and 100 or nil, -- Lesser Invisibility
[3680] = 100, -- Lesser Invisibility
[4079] = 200, -- Cloaking
[4952] = 200, -- Helcular's War
[5543] = 500, -- Fade Out
[6298] = 200, -- Form of the Moonstalker
[7870] = IsWotlk and 200 or 100, -- Lesser Invisibility
[8611] = 5000, -- Phase Shift
[885] = 200, -- Invisibility
[9095] = -1000, -- Cantation of Manifestation
[9587] = 200, -- Magic Potion
[9738] = -1000, -- Rift Spawn Becomes Visible
[10228] = 300, -- Greater Invisibility
[11392] = 200, -- Invisibility
[12332] = 10000, -- Lathoric the Black
[12845] = 100, -- Lesser Invisibility
[16380] = 300, -- Greater Invisibility
[17651] = 5000, -- Image Projection
[20672] = 500, -- Fade
[23452] = 300, -- Invisibility
[24235] = 10000, -- Super Invis
[25905] = 10000, -- Invis Self
[26222] = 10000, -- Super Invis
[28500] = 200, -- Invisibility
[29309] = 5000, -- Phase Shift
[32943] = 300, -- Phasing Invisibility
[29627] = 200, -- Nether Step
[29921] = 150, -- Phasing Invisibility
[30447] = 50, -- Shadow of the Forest
[30448] = 100, -- Shadow of the Forest
[32612] = 340, -- Invisibility
[32811] = 300, -- Greater Invisibility
[41253] = 300, -- Greater Invisibility
[44312] = 9999, -- Head of the Horseman Invisible
[46021] = 350, -- Spectral Realm
[49399] = 100, -- Skeleton Invis
[50700] = 350, -- Copy of Spectral Realm (Test)
[54436] = 600, -- Demonic Empowerment
[55848] = 1000, -- Invisibility
[69107] = 300, -- Killing Spree Invis Aura
[72343] = 400, -- Hallucination
[440505] = 200, -- Invisibility
[441785] = 101, -- Drained of Blood
[1221579] = 201, -- Super Invis
[1227700] = 201, -- Invisibility
[1231389] = 10000, -- Vanish
},
[1] = {
[8203] = 1000, -- Elemental Spirit Invisibility
},
[2] = {
[17680] = 1, -- Spirit Spawn-out
[24221] = 1, -- Quest - Teleport Spawn-out
[24699] = 10000, -- Vanish
[36748] = 1, -- Smoke Spawn-out
[448779] = 5001, -- Wake Up Dead
[459280] = 101, -- Transiting Realities
[1234595] = 10000, -- Vanish
},
[4] = {
[12495] = 1000, -- Eranikus the Chained Invisibility
[29448] = 9999, -- Vanish
[32727] = 100, -- Arena Preparation
[32754] = 100, -- Invisibility
[34341] = 9999, -- Ember Blast
[38544] = 300, -- Coax Marmot
[39667] = 9999, -- Vanish
[41476] = 9999, -- Vanish
[44036] = 340, -- Fade
[44199] = 9999, -- Ember Blast
[49337] = 1000, -- Racer Slam death scene: car flip Parent
[50008] = 1, -- BOTM - Jungle Brew - Jungle Invisibility Aura
[50015] = 9999, -- You're a ...! (NPC) Death Scene
[55964] = 9999, -- Vanish
[74069] = 100, -- Spawn Invisibility Aura
},
[5] = {
[56783] = 50, -- Quest Invis Tier 4
},
[7] = {
[23303] = 100, -- Vaelen the Flayed [The Shadow Vault] - Invisibility
[27622] = 100, -- Get the Key: Vaelen's Invisibility & See Invisibility
[37754] = 5000, -- Through The Eyes of Gorefiend
[38012] = 5000, -- Garm Wolfbrother: Invisibility
[43890] = 1000, -- Flying Machine Invisibility
[45636] = 100, -- Mist of the Kvaldir
[50734] = 1000, -- Frenzyheart Chicken: Invisibility
[52060] = 300, -- Invisibility
[54500] = 1000, -- Quest Invisibility 1
[56304] = 350, -- Hodir's Helm Bunny: Invisibility
[56768] = 50, -- Quest Invis Tier 1
[56779] = 50, -- Quest Invis Tier 1
[57744] = 1000, -- Quest Invisibility 1
[59649] = 99, -- Icecrown Bomber - Cloak Dome Bunny
[60190] = 1000, -- Invisibility
[60464] = 9, -- Cloaked Alliance Peeps
[70693] = 1000, -- Uther Despawn
[74980] = 1000, -- Spy Frog Invisibility
[75779] = 1000, -- [DND] Marker
[1221135] = 101, -- Torment's Illusion
},
[8] = {
[34840] = 1000, -- Triangulation Point One Invisibility
[34858] = 2000, -- Triangulation Point Two Invisibility
[40194] = 1000, -- Bombing Run: Invisibility
[51113] = 500, -- Monte Muzzleshot's Invisibility (Mangal)
[51114] = 250, -- Monte Muzzleshot's Invisibility (Camp)
[54503] = 1000, -- Quest Invisibility 2
[56058] = 100, -- Get the Key: Instructor Hroegar's Invisibility
[59660] = 999, -- Inside Cloak Dome Individual
[60191] = 1000, -- Invisibility
[60481] = 9, -- Cloaked Horde Peeps
[73973] = 1000, -- Poster Location Marker
[75433] = 100, -- Spawn Invisibility Aura (QZS 2)
},
[9] = {
[39596] = 1000, -- Ethereum Relay
[39680] = 5000, -- Sai'kkal Invisibility
[42175] = 5000, -- Evidence Marker Invis
[52213] = 1000, -- Rainspeaker Treasures: Invisibility
[61208] = 300, -- Fjorn's Anvil - Quest Invisibility 3
[74144] = 1000, -- Poster Location Marker
[74466] = 1000, -- Raging Fire Elemental Invisibility
[75165] = 1000, -- Spirit of the Tiger Aura
[75166] = 1000, -- Spirit of the Tiger Aura (Rider)
[75179] = 1000, -- Matriarch's Shroud
},
[10] = {
[44856] = 100, -- Bash'ir Phasing Device
[45614] = 300, -- Shroud of the Scourge
[48809] = 48812, -- Binding Life
[49097] = 100, -- Out of Body Experience
[52215] = 1000, -- Kartak and Sparktouched: Invisibility
[75513] = 1000, -- Spawn Invisibility Aura (QZM)
[364459] = 1000, -- Shroud of Death
[426062] = 101, -- Quest Invisibility
[462593] = 101, -- Quest Invisibility
[468882] = 101, -- Quest Invisibility
},
[28] = {
[425147] = 101, -- Quest Invisibility
},
},
IsFeralForm = {
[768] = true, -- Cat Form
[5487] = true, -- Bear Form
Expand Down Expand Up @@ -112,6 +264,15 @@ Data.Aura = {
[49280] = true, -- Lightning Shield rank 10
[49281] = true, -- Lightning Shield rank 11
},
IsProwlOrStealth = {
[1784] = true, -- Stealth
[1785] = true, -- Stealth
[1786] = true, -- Stealth
[1787] = true, -- Stealth
[5215] = true, -- Prowl
[6783] = true, -- Prowl
[9913] = true, -- Prowl
},
MP5 = {
[430] = 42, -- drink
[431] = 104, -- drink
Expand Down Expand Up @@ -422,6 +583,77 @@ Data.Aura = {
[1227200] = 20, -- Wickedness
[1236220] = -50, -- Slow
},
Stealth = {
[1784] = 5, -- Stealth
[1785] = 100, -- Stealth
[1786] = 200, -- Stealth
[1787] = 300, -- Stealth
[2425] = -100, -- Spotted
[3648] = 5, -- Phase Out
[5215] = 100, -- Prowl
[5916] = 1, -- Shadowstalker Stealth
[6408] = 1, -- Faded
[6538] = 140, -- Dig Trap
[6634] = (IsClassic and 6 or 300), -- Phasing Stealth
[6783] = 200, -- Prowl
[6920] = 100, -- Hide
[8152] = 5, -- Prowl
[8218] = 5, -- Sneak
[8822] = 9999, -- Stealth
[9736] = 180, -- Arantir's Deception
[9740] = 180, -- Arantir's Deception
[9913] = 300, -- Prowl
[10032] = 9999, -- Uber Stealth
[11327] = 170, -- Vanish
[11329] = 270, -- Vanish
[16122] = 99999, -- Phasing
[20540] = 5, -- Ashenvale Outrunner Sneak
[20580] = 50, -- Shadowmeld
[22766] = 1, -- Sneak
[24450] = 150, -- Prowl
[24452] = 200, -- Prowl
[24453] = 250, -- Prowl
[24690] = 1000, -- Aspect of Arlokk
[26381] = 10000, -- Burrow
[26888] = 370, -- Vanish
[29448] = 9999, -- Vanish
[30831] = 1, -- Stealth
[30991] = 1, -- Stealth
[31526] = 9999, -- Stealth
[31621] = 9999, -- Stealth
[32199] = 65, -- Stealth
[32615] = 1, -- Stealth
[34189] = -50, -- Stealth
[35205] = 9999, -- Vanish
[39581] = 10000, -- Storm Blink
[42347] = 1, -- Stealth
[42866] = 9999, -- Stealth
[42932] = 1, -- Prowl
[42943] = 9999, -- Stealth
[47521] = 9999, -- Mole Machine Player Hide and Root
[51755] = 600, -- Camouflage
[52006] = 5000, -- Shroud
[53061] = 1000, -- Cover
[58548] = 4200, -- Ethereal
[59045] = 300, -- Camoflogue
[61704] = 1, -- Sneaky Walk
[66296] = 350, -- Shadow Veil
[66305] = 300, -- Shadow Veil
[67340] = 100, -- Hide
[448471] = 101, -- Lledra's Vehicle Test [DNT]
[460631] = 251, -- (DNT) Pyranis Add Fog Stealth
[467049] = 301, -- Blessing of Bethekk
[469182] = 11, -- Lying Low
[473544] = 5, -- Sneaking
[1220930] = 10000, -- Phantom's Veil
[1221341] = 6, -- Poorly Camouflaged
[1231389] = 10000, -- Vanish
},
StealthEffectiveness = {
[28492] = 30, -- Sneaking
[38552] = 8, -- Improved Stealth
[1220708] = 8, -- Displaced
},
}
Data.Enchant = {
BlockValue = {
Expand Down Expand Up @@ -458,6 +690,10 @@ Data.Enchant = {
[3836] = 8, -- Master's Inscription of the Crag
[7099] = 12, -- Blackfathom Mana Oil. This effect only applies within Blackfathom Deeps.
},
StealthEffectiveness = {
[910] = 5, -- Enchant Cloak - Stealth
[3256] = 5, -- Enchant Cloak - Shadow Armor
},
}
Data.Gem = {
MP5 = {
Expand Down Expand Up @@ -778,6 +1014,25 @@ Data.Item = {
[242315] = 3,
[242317] = 3,
},
StealthEffectiveness = {
[8197] = 5, -- Nightscape Boots
[20255] = 5, -- Whisperwalk Boots
[21758] = 3, -- Figurine - Black Pearl Panther
[22003] = 8, -- Darkmantle Boots
[23073] = 8, -- Boots of Displacement
[24128] = (IsTBC and 5 or nil), -- Figurine - Nightseye Panther
[27467] = 5, -- Silent-Strider Kneeboots
[31228] = 5, -- The Master's Treads
[35702] = (IsTBC and 5 or nil), -- Figurine - Shadowsong Panther
[213341] = 5, -- Insulated Workboots
[219343] = 3, -- Filcher's Cowl
[220860] = 5, -- Sergeant Major's Leather Boots
[220861] = 5, -- First Sergeant's Leather Boots
[221409] = 5, -- Emerald Leather Sabatons
[226831] = 8, -- Darkmantle Footpads
[226851] = 8, -- Darkmantle Boots
[236314] = 8, -- Boots of Displacement
},
TimewornSpellHaste = {
[234016] = 2,
[234020] = 2,
Expand All @@ -802,3 +1057,12 @@ Data.setNames = {
VESTMENTS_OF_TRANSCENDENCE = "Vestments of Transcendence",
WINDHAWK_ARMOR = "Windhawk Armor",
}
Data.Talent = {
[Data.DRUID] = {
FERAL_INSTINCT = (IsClassic and {16947,16948,16949,16950,16951} or {16947,16948,16949})
},
[Data.ROGUE] ={
MASTER_OF_DECEPTION = (IsWotlk and {13958,13970,13971} or {13958,13970,13971,13972,13973})
},
}

2 changes: 2 additions & 0 deletions Modules/Data/Data.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ end

dataFunctionRefs = {
["MovementSpeed"] = function() return Data:GetMovementSpeed() end,
["Stealth"] = function() return Data:GetStealthValue() end,
["Invisibility"] = function() return Data:GetInvisibility() end,
-- Melee
["MeleeAttackPower"] = function() return Data:GetMeleeAttackPower() end,
["MeleeCritChance"] = function() return Data:MeleeCrit() end,
Expand Down
Loading
Loading