Integrate PDF generation

[Brandon-Anubis]

Summary

• implement PDF saving via FileManager
• mark clipping task as complete
• update plan and tasks documentation

Testing

• python validate_docs.py
• pytest -q

---

https://chatgpt.com/codex/tasks/task_e_68671acce1908321a9bec5cc891a9c21

[gemini-code-assist]

Summary of Changes

Hello @Brandon-Anubis, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly advances the web clipping functionality by implementing robust PDF generation capabilities. It centralizes file saving operations through a dedicated FileManager and updates project documentation to reflect the completion of this key feature.

Highlights

• Centralized File Management: Both Markdown and PDF file saving operations have been refactored to utilize dedicated methods within the FileManager (save_markdown and save_pdf), centralizing file handling logic and improving modularity.
• Documentation Updates: The project's PLAN.md and TASKS.md documentation have been updated to reflect the successful integration of PDF generation and the completion of TASK-002.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request integrates PDF generation by delegating file saving to the FileManager. My review identifies a high-severity performance issue where synchronous file I/O operations block the asyncio event loop, and a medium-severity maintainability issue due to code duplication. Addressing these points will improve the application's performance and maintainability.

[gemini-code-assist]

The save_markdown and save_pdf methods perform synchronous file I/O, which will block the asyncio event loop when called from an async function like clip. This can degrade application performance and responsiveness, especially as PDF generation can be a slow process. Consider executing these blocking calls in a thread pool executor. You can use asyncio.gather to run them concurrently for better performance.

This same issue exists in the single-URL processing logic block as well (lines 110-113).

loop = asyncio.get_running_loop()
markdown_info, pdf_info = await asyncio.gather(
    loop.run_in_executor(
        None, self.file_manager.save_markdown, final_doc, timestamp, url
    ),
    loop.run_in_executor(
        None, self.file_manager.save_pdf, final_doc, timestamp, url
    ),
)

[gemini-code-assist]

This block of code for saving files is nearly identical to the one for handling sitemaps on lines 72-75. To improve maintainability and adhere to the Don't Repeat Yourself (DRY) principle, consider refactoring this duplicated logic into a private helper method. This would also be a good place to apply the fix for the blocking I/O issue mentioned in the other comment, solving it in one central place.

async def _save_artifacts_and_get_result(self, final_doc: str, timestamp: str, url: str, title: str) -> dict:
    loop = asyncio.get_running_loop()
    markdown_info, pdf_info = await asyncio.gather(
        loop.run_in_executor(
            None, self.file_manager.save_markdown, final_doc, timestamp, url
        ),
        loop.run_in_executor(
            None, self.file_manager.save_pdf, final_doc, timestamp, url
        ),
    )

    return {
        "title": title,
        "url": url,
        "markdown_path": markdown_info["relative_path"],
        "pdf_path": pdf_info["relative_path"],
        "timestamp": timestamp,
        "status": "completed",
        "preview": (
            final_doc[:500] + "..." if len(final_doc) > 500 else final_doc
        ),
    }