Feature 224#247
Closed
mansory-01 wants to merge 19 commits into
Closed
Conversation
Closes Boxkit-Labs#221 - Implement FilterDeposit function with proper warning-to-decision mapping - Add 15 comprehensive table-driven test cases covering all scenarios: * Clean muxed routing * Clean memo routing * No routing source * Contract sender warning * Invalid destination warning * Memo ignored for muxed warning * Multiple warnings with severity prioritization * Edge cases (empty/invalid addresses) - Use standard Go testing patterns with t.Run() subtests - Test names describe scenarios, not expected results - All tests pass with go test ./firewall/ -v
…-table-driven-tests feat: Add comprehensive table-driven tests for FilterDeposit
…rruption-Comparision feat(auditor): add single address precision comparison CLI
- Add Decision type: AutoCredit, ManualReview, Quarantine - Implement FilterDeposit function with warning-to-decision mapping - Add missing warning types: SMART_ACCOUNT_AMBIGUOUS_ROUTING, MUXED_DESTINATION_FROM_CONTRACT - Map contract-sender and invalid-destination warnings to Quarantine - Map memo-ignored and smart-account-ambiguous warnings to ManualReview - Implement highest severity resolution for multiple warnings - Add comprehensive test suite with 10 test cases - Include inline security rationale comments for each mapping Closes Boxkit-Labs#220
- Resolved merge conflicts in filter.go by keeping both FilterDeposit functions - Added FilterDepositFromAddress helper function for address string input - Resolved merge conflicts in tests by keeping both test approaches - Fixed go.mod conflicts to maintain local package path - All tests passing with comprehensive coverage
…tion-Sweep feat(auditor): add batch ID precision sweep (Number vs BigInt)
…ruption-Comparision
…Corruption-Comparision Feat/single address corruption comparision
Implement Routing Analysis for Exchange Withdrawal Validator
…-Labs#221) - Remove filter_simple.go and consolidate into single filter.go - Consolidate all test cases into single filter_test.go - Remove duplicate test files (filter_demo_test.go, filter_mock_test.go, filter_standalone_test.go) - Remove conflicting demo.go file - Fix FilterDeposit function to use string parameter with routing extraction - Add filterDepositFromResult helper function for core logic - All tests now pass with consolidated implementation - Clean up test structure and remove overlapping functionality This addresses both issues Boxkit-Labs#220 and Boxkit-Labs#221 by eliminating duplicate implementations and consolidating all test cases into a single, clean test file.
FilterDeposit implementation and tests
|
@mansory-01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses compilation errors caused by conflicting event names and incorrect import paths during the introduction of the new analysis panels.
Changes Made
AddressChangedevent toSafeAddressChanged(insafe_bloc.dart) andUnsafeAddressChanged(inunsafe_bloc.dart) to resolve a naming collision, since both BLoCs are imported intounsafe_panel.dart.app.dartandhome_screen.dartto use absolute package imports (package:stellar_address_kit_demo/...) so the Dart analyzer correctly resolvesSafeBloc,UnsafePanel, andSafePanel.unsafe_panel.dartandanalyze_panel.dartto dispatch the newly renamed, BLoC-specific events.closes #224