Skip to content

Added check for null terminated string in title #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nexus4880 wants to merge 3 commits into
base: imgui
Choose a base branch
from
Open

Added check for null terminated string in title #12

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b815f5e
Added check for null terminated string in title
nexus4880 Feb 27, 2025
43dd8bb
Updated braces to match your style
nexus4880 Feb 27, 2025
831fc8c
I had forgotten to prefix the title with "Title: "
nexus4880 Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/DMG/MBC.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
using System.Text;

class MBC {
//MBC is currently only experimental
//MBC0/ROM Only should be good
Expand Down Expand Up @@ -106,17 +108,15 @@ private int CalculateRomSize(byte headerValue) {
}

public string GetTitle() {
byte[] titleBytes = new byte[16];
Array.Copy(rom, 0x0134, titleBytes, 0, 16);

string title = System.Text.Encoding.ASCII.GetString(titleBytes).TrimEnd(null);
Copy link
Copy Markdown

@markvantilburg markvantilburg May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.TrimEnd('\0')

should also solve this issue


if (title.Length > 16)
{
title = title.Substring(0, 16);
int titleStart = 0x0134;
int titleLength;
for (titleLength = 0; titleLength < 16; titleLength++) {
if (rom[titleStart + titleLength] == 0) {
break;
}
}

Copy link
Copy Markdown

@markvantilburg markvantilburg May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this if needed if the Array is 16 long?

return "Title: " + title;
string title = Encoding.ASCII.GetString(rom, titleStart, titleLength);
return $"Title: {title}";
}

public string GetCartridgeType() {
Expand Down