Skip to content

Conversation

@Qile0317
Copy link
Contributor

@Qile0317 Qile0317 commented Nov 2, 2025

As per the title, this PR reimplements most changes that were overwritten during the bioconductor release. Here are the changes:

  • removed rlang from Imports (since only %||% was imported)
  • Reformatted NEWS and README.md
  • As per basilisk documentation:
    • Add .BBSoptions with UnsupportedPlatforms: win32
    • Add configure and configure.win scripts
  • Add Docker infrastructure with Dockerfile and .devcontainer/devcontainer.json
  • Add .markdownlint.json to sourcecode
  • Improved testthat compatibility across platforms
  • Added back myself as contributor
  • Made actions run on devel branches too

Notably, I have not yet reimplemented the ibex vector methods because I'm gonna try to improve on some design decisions.

Also, the three files added as per the basilisk documentation may or may not cause issues with Bioconductor so I'll keep a watch if it gets on there and the devel build blows up. But so far locally everything is fine and all tests and builds are passing.

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
R/CoNGAfy.R 74.78% <ø> (ø)
R/utils.R 79.48% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Qile0317 Qile0317 changed the base branch from main to devel November 3, 2025 04:13
@ncborcherding ncborcherding merged commit 4305271 into BorchLab:devel Nov 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants