-
Notifications
You must be signed in to change notification settings - Fork 4
Reimplement some overwritten changes from #20 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title, this PR reimplements most changes that were overwritten during the bioconductor release. Here are the changes:
%||%was imported)NEWSandREADME.mdbasiliskdocumentation:.BBSoptionswithUnsupportedPlatforms: win32configureandconfigure.winscriptsDockerfileand.devcontainer/devcontainer.json.markdownlint.jsonto sourcecodeNotably, I have not yet reimplemented the ibex vector methods because I'm gonna try to improve on some design decisions.
Also, the three files added as per the basilisk documentation may or may not cause issues with Bioconductor so I'll keep a watch if it gets on there and the devel build blows up. But so far locally everything is fine and all tests and builds are passing.