feat: Add CacheControlMiddleware to manage caching headers in responses #1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/middleware/cache_control.py
Outdated
| """ | ||
| Middleware to control caching headers. | ||
| - For 4xx and 5xx responses: enforce no-store/no-cache headers and remove validators. | ||
| - For other responses: mirror incoming request's Cache-Control/Pragma/ETag/Expires if present. |
Member
There was a problem hiding this comment.
[qa]
If possible, I’d like to understand the intent behind mirroring request headers (Cache-Control/Pragma/ETag/Expires) into the response for non-error cases, especially for ETag/Expires.
Member
Author
There was a problem hiding this comment.
Sorry. There is no need for mirroring other than Cache-Control. I have deleted it.
purplesmoke05
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Description
This pull request introduces a new middleware to manage HTTP caching headers based on response status codes, improving cache control and compliance with RFC9111/RFC7231.
✅ Related Issues
None
🔄 Changes
Middleware Addition and Integration
CacheControlMiddlewareto the codebase, which enforces cache header policies by status code, allowing cache only for specific whitelisted statuses (e.g., 200, 301, 404) and disabling cache for others. (app/middleware/cache_control.py)CacheControlMiddlewarein the middleware initialization and main application setup, ensuring it is applied to all incoming requests. (app/middleware/__init__.py,app/main.py) [1] [2] [3]📌 Checklist