This repository was archived by the owner on Feb 29, 2024. It is now read-only.
Give each ansible-runner task its own virtualenv#403
Open
gandelman-a wants to merge 1 commit intoBonnyCI:masterfrom
Open
Give each ansible-runner task its own virtualenv#403gandelman-a wants to merge 1 commit intoBonnyCI:masterfrom
gandelman-a wants to merge 1 commit intoBonnyCI:masterfrom
Conversation
We currently share a base virtualenv among ansible-runner tasks, into which we install ansible, datadog callbacks, ara and requirements for all ansible-runners. This is problematic because 1) ansible-runners that do not run as root require sudo access to update the virtualenv 2) we can potentially end up with version conflicts among dependencies Instead, this sets up isolated virtualenvs for each runner task, each with their own callbacks, dependency set, etc. Closes-issue: BonnyCI/projman#242 Signed-off-by: Adam Gandelman <adamg@ubuntu.com>
Contributor
ConsoleCatzirl
left a comment
ConsoleCatzirl
left a comment
There was a problem hiding this comment.
+1 from me, but I think this could use a second set of eyes before approving.
Contributor
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently share a base virtualenv among ansible-runner tasks, into
which we install ansible, datadog callbacks, ara and requirements for
all ansible-runners. This is problematic because 1) ansible-runners
that do not run as root require sudo access to update the virtualenv
2) we can potentially end up with version conflicts among dependencies
Instead, this sets up isolated virtualenvs for each runner task, each with
their own callbacks, dependency set, etc.
Closes-issue: BonnyCI/projman#242
Signed-off-by: Adam Gandelman adamg@ubuntu.com