Skip to content
This repository was archived by the owner on Feb 29, 2024. It is now read-only.

Update vagrant nodepool provider#378

Open
ConsoleCatzirl wants to merge 1 commit intoBonnyCI:masterfrom
ConsoleCatzirl:vagrant-nodepool
Open

Update vagrant nodepool provider#378
ConsoleCatzirl wants to merge 1 commit intoBonnyCI:masterfrom
ConsoleCatzirl:vagrant-nodepool

Conversation

@ConsoleCatzirl
Copy link
Copy Markdown
Contributor

Update the nodepool provider defined in the vagrant group vars to
work with the current opentechsjc network setup. There are multiple
networks, so we must specify one to use. Also reduce the minimum nodes
to reduce resource overhead.

Signed-off-by: K Jonathan Harker Jonathan.Harker@ibm.com

Copy link
Copy Markdown
Contributor

@gandelman-a gandelman-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a similar change to the allinone inventory i was just about to push up.... a couple comments

Comment thread inventory/group_vars/vagrant Outdated
- name: cicloud
cloud: cicloud
max-servers: 10
max-servers: 3
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for developers, we should probably keep this to 1 by default just to ease resource usage on the cloud

Comment thread inventory/group_vars/vagrant Outdated
max-servers: 3
images:
- name: ubuntu-xenial
min-ram: 2048
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can bump this down to 512 as well to conserve resources

private-key: /var/lib/nodepool/.ssh/id_rsa
networks:
- name: 'nodepool'
public: False
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we want to encourage devs to boot slaves on our production nodepool environment. We could instead default to the 'internal' network and the slaves should be reachable via fixed ip from the dev env, assuming it to was booted on the internal network.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, tip: we also need user-home and username set on the image so that nodepool, otherwise it defaults to jenkins

Update the nodepool provider defined in the vagrant group vars to
work with the current opentechsjc network setup. There are multiple
networks, so we must specify one to use. Also reduce the minimum nodes
to reduce resource overhead.

Signed-off-by: K Jonathan Harker <Jonathan.Harker@ibm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants