Auto create PBI is done by ravi-bhatt-btc · Pull Request #1 · BoTreeTechnologies/redmine-plugin-scrum

ravi-bhatt-btc · 2016-12-09T06:57:03Z

Changes made to creat PBI after Creating sprint.

amitpatelx · 2016-12-09T07:01:04Z

app/controllers/sprints_controller.rb

        raise 'Fail to update project with product backlog' unless @project.save!
      end
      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, "sprint_id"=> @sprint.id, "subject"=>"#{@sprint.name} pbi", "status_id"=> IssueStatus.find_by_name('In Progress').id , "priority_id"=> Enumeration.find_by_name('Normal').id, "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, "due_date"=>@sprint.sprint_end_date, "estimated_hours"=>"", "done_ratio"=>"0", "custom_field_values"=>{ "#{CustomField.find_by_name('Story Points').id}"=>"#{CustomField.find_by_name('Story Points').default_value}"}, "description"=>""}}


Line is too long. Separate each key value pair in new line

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:40Z

app/controllers/sprints_controller.rb

        raise 'Fail to update project with product backlog' unless @project.save!
      end
      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 


Remove trailing whitespace

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:42Z

app/controllers/sprints_controller.rb

        raise 'Fail to update project with product backlog' unless @project.save!
      end
      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 


Space inside { missing.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:43Z

app/controllers/sprints_controller.rb

        raise 'Fail to update project with product backlog' unless @project.save!
      end
      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 


Prefer single-quoted strings when you don't need string interpolation or special symbols.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:44Z

app/controllers/sprints_controller.rb

        raise 'Fail to update project with product backlog' unless @project.save!
      end
      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 


Surrounding space missing for operator =>.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:45Z

app/controllers/sprints_controller.rb

        raise 'Fail to update project with product backlog' unless @project.save!
      end
      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 


Line is too long. [89/80]

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:46Z

app/controllers/sprints_controller.rb

        raise 'Fail to update project with product backlog' unless @project.save!
      end
      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 


Trailing whitespace detected.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:48Z

app/controllers/sprints_controller.rb

+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 
+                              "due_date"=>@sprint.sprint_end_date, 
+                              "estimated_hours"=>"", "done_ratio"=>"0", 
+                              "custom_field_values"=>{ "#{CustomField.find_by_name('Story Points').id}"=>"#{CustomField.find_by_name('Story Points').default_value}"},


Calls 'customfield.find_by_name('story points')' 2 times (DuplicateMethodCall)

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:49Z

app/controllers/sprints_controller.rb

+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 
+                              "due_date"=>@sprint.sprint_end_date, 
+                              "estimated_hours"=>"", "done_ratio"=>"0", 
+                              "custom_field_values"=>{ "#{CustomField.find_by_name('Story Points').id}"=>"#{CustomField.find_by_name('Story Points').default_value}"},


Prefer single-quoted strings when you don't need string interpolation or special symbols.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:50Z

app/controllers/sprints_controller.rb

+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 
+                              "due_date"=>@sprint.sprint_end_date, 
+                              "estimated_hours"=>"", "done_ratio"=>"0", 
+                              "custom_field_values"=>{ "#{CustomField.find_by_name('Story Points').id}"=>"#{CustomField.find_by_name('Story Points').default_value}"},


Surrounding space missing for operator =>.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:51Z

app/controllers/sprints_controller.rb

+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 
+                              "due_date"=>@sprint.sprint_end_date, 
+                              "estimated_hours"=>"", "done_ratio"=>"0", 
+                              "custom_field_values"=>{ "#{CustomField.find_by_name('Story Points').id}"=>"#{CustomField.find_by_name('Story Points').default_value}"},


Prefer to_s over string interpolation.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:53Z

app/controllers/sprints_controller.rb

+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 
+                              "due_date"=>@sprint.sprint_end_date, 
+                              "estimated_hours"=>"", "done_ratio"=>"0", 
+                              "custom_field_values"=>{ "#{CustomField.find_by_name('Story Points').id}"=>"#{CustomField.find_by_name('Story Points').default_value}"},


Line is too long. [166/80]

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:54Z

app/controllers/sprints_controller.rb

+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 
+                              "due_date"=>@sprint.sprint_end_date, 
+                              "estimated_hours"=>"", "done_ratio"=>"0", 
+                              "custom_field_values"=>{ "#{CustomField.find_by_name('Story Points').id}"=>"#{CustomField.find_by_name('Story Points').default_value}"},


Space inside } missing.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:55Z

app/controllers/scrum_controller.rb

-    rescue Exception => @exception
-      logger.error("Exception: #{@exception.inspect}")
-    end
+   create_pbi_auto(params)


Use 2 (not 1) spaces for indentation.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:56Z

app/controllers/sprints_controller.rb

      end
      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 


Prefer single-quoted strings when you don't need string interpolation or special symbols.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:58Z

app/controllers/sprints_controller.rb

      end
      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 


Surrounding space missing for operator =>.

ParthBarot-BoTreeConsulting · 2016-12-09T07:19:59Z

app/controllers/sprints_controller.rb

      end
      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 


Trailing whitespace detected.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:00Z

app/controllers/sprints_controller.rb

      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 


Prefer single-quoted strings when you don't need string interpolation or special symbols.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:02Z

app/controllers/sprints_controller.rb

      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 


Surrounding space missing for operator =>.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:04Z

app/controllers/sprints_controller.rb

      flash[:notice] = l(:notice_successful_create)
+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 


Trailing whitespace detected.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:07Z

app/controllers/sprints_controller.rb

+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 


Prefer single-quoted strings when you don't need string interpolation or special symbols.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:08Z

app/controllers/sprints_controller.rb

+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 


Surrounding space missing for operator =>.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:10Z

app/controllers/sprints_controller.rb

+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 


Line is too long. [89/80]

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:11Z

app/controllers/sprints_controller.rb

+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 


Space found before comma.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:12Z

app/controllers/sprints_controller.rb

+      pbi_params = {"issue"=>{"tracker_id"=> Tracker.find_by_name('Product Backlog').id, 
+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 


Trailing whitespace detected.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:14Z

app/controllers/sprints_controller.rb

+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 


Prefer single-quoted strings when you don't need string interpolation or special symbols.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:15Z

app/controllers/sprints_controller.rb

+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 


Surrounding space missing for operator =>.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:16Z

app/controllers/sprints_controller.rb

+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 


Line is too long. [85/80]

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:18Z

app/controllers/sprints_controller.rb

+                              "sprint_id"=> @sprint.id, 
+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 


Trailing whitespace detected.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:19Z

app/controllers/sprints_controller.rb

+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 
+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 


Prefer single-quoted strings when you don't need string interpolation or special symbols.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:20Z

app/controllers/sprints_controller.rb

+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 
+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 


Surrounding space missing for operator =>.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:22Z

app/controllers/sprints_controller.rb

+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 
+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 


Line is too long. [93/80]

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:23Z

app/controllers/sprints_controller.rb

+                              "subject"=>"#{@sprint.name} pbi", 
+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 
+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 


Trailing whitespace detected.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:24Z

app/controllers/sprints_controller.rb

+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 
+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 
+                              "due_date"=>@sprint.sprint_end_date, 


Prefer single-quoted strings when you don't need string interpolation or special symbols.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:26Z

app/controllers/sprints_controller.rb

+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 
+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 
+                              "due_date"=>@sprint.sprint_end_date, 


Surrounding space missing for operator =>.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:27Z

app/controllers/sprints_controller.rb

+                              "status_id"=> IssueStatus.find_by_name('In Progress').id , 
+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 
+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 
+                              "due_date"=>@sprint.sprint_end_date, 


Trailing whitespace detected.

ParthBarot-BoTreeConsulting · 2016-12-09T07:20:28Z

app/controllers/sprints_controller.rb

+                              "priority_id"=> Enumeration.find_by_name('Normal').id, 
+                              "assigned_to_id"=>"", "start_date"=>@sprint.sprint_start_date, 
+                              "due_date"=>@sprint.sprint_end_date, 
+                              "estimated_hours"=>"", "done_ratio"=>"0", 


Prefer single-quoted strings when you don't need string interpolation or special symbols.

Auto create PBI is done

88c30dd

amitpatelx reviewed Dec 9, 2016

View reviewed changes

Lines justified

dafa361

ParthBarot-BoTreeConsulting reviewed Dec 9, 2016

View reviewed changes

ravi-bhatt-btc added 3 commits December 9, 2016 16:57

changes made to remove dependancies on redmine's code

1485bfe

changes made after testing

613bb0a

added missing keyword in method

d6af9e9

Conversation

ravi-bhatt-btc commented Dec 9, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels