BUG: New implementation for ComputeNeighborhoods filter #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
force-pushed
the
topic/compute_neighborhoods_fixes
branch
5 times, most recently
from
25137e2 to
47ab106
Compare
JDuffeyBQ
reviewed
Dec 15, 2025
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/ComputeNeighborhoods.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/ComputeNeighborhoods.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/ComputeNeighborhoods.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/ComputeNeighborhoods.cpp
Show resolved
Hide resolved
imikejackson
force-pushed
the
topic/compute_neighborhoods_fixes
branch
4 times, most recently
from
c73e7f1 to
278ff04
Compare
The previous implementation has issues with the binning system and will only find that a centroid is within a radius if both centroids fall into the same bin. New unit test file was created and hand verified by MAJ.
imikejackson
force-pushed
the
topic/compute_neighborhoods_fixes
branch
from
278ff04 to
0df1a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation has issues with the binning system and will only find that a centroid is within a radius if both centroids fall into the same bin.