BUG/ENH: Fix Backwards Pipeline Compatibility and Add Testing #1476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nyoungbq Just tried a quick test and I copied the (08) SmallIN100 Full Reconstruction from DREAM.3D version 6.5.171 into DREAM3D-NX and looks like it is mostly correct but I got an error on filter 13 about a missing data array path and the issue was in filter 11 "Compute Feature Average Orientations", the "Feature Attribute Matrix" was not set correctly or transferred correctly from the old pipeline. |
Contributor
Author
|
@imikejackson okay I will pull all the default pipelines from 6.5.171 and test/patch for them. The mega-pipeline generated for this was from 6.6 |
imikejackson
force-pushed
the
bug/conversion_testing
branch
from
aa07206 to
cad0018
Compare
nyoungbq
force-pushed
the
bug/conversion_testing
branch
from
cad0018 to
49ac2e7
Compare
imikejackson
force-pushed
the
bug/conversion_testing
branch
from
73569ef to
0428742
Compare
imikejackson
force-pushed
the
bug/conversion_testing
branch
2 times, most recently
from
a9a69f3 to
a566f7e
Compare
- Assorted Parameter Fixes - Conversion Function Updates - Assorted SnxCore filter fixes
imikejackson
force-pushed
the
bug/conversion_testing
branch
from
a566f7e to
cffd9d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion updates
Test Added
Has a sibling branch on
SimplnxReviewThe tool to generate the test data is on the SIMPL repo
Testing Methodology:
6.6a "mega-pipeline" was generated with values according to parameter type. This not only verifies that the values are read in, but that they are read in correctly. Any exclusions (ie new filter parameters) must be explicitly excluded. Any new filter registered to the Plugin UUID conversion maps will be tested automatically.6.5.171every default pipeline was updated to the6.5.171release standard (except synthetics, noted inREADMEin test data). These are validated that the values are read in and that they match the expected type. Any new filter registered to the Plugin UUID conversion maps will be tested automatically, SO LONG AS IT APPEARS IN THE DEFAULT6.5.171PIPELINES.Note any filter that is not in a plugin-level conversion UUID map will NOT be tested.
Also note that just because it reads them in properly does not mean the pipeline cannot be run without errors. Example: consider a real case where an AttributeMatrix was hard-coded to the name
vertex datain SIMPL, thus filters that follow in the pipeline may have the path../vertex data/... However, insimplnxthe filter was made more general and thus usescell dataas the hard-coded AM name, thus filters that follow in the pipeline may have the path../cell data/... When conversion occurs the../vertex data/..is read in properly, but the array actually exists at../cell data/..causing a disparity.