FIX: separate get doctor api to auth and non-auth #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
token 없는 경우 GET 요청 수정
|
jshong0907
reviewed
Jan 19, 2022
| * GET method만 허용한다. | ||
| """ | ||
| queryset = Doctor.objects.all() | ||
| permission_classes = [IsAuthenticated] |
Member
There was a problem hiding this comment.
permission class IsDoctor를 만들어도 좋을 것 같아요.
Comment on lines
+73
to
+76
| if queryset is None: | ||
| queryset = self.get_queryset() | ||
|
|
||
| return queryset.filter(user=self.request.user).get() |
Member
There was a problem hiding this comment.
Suggested change
| if queryset is None: | |
| queryset = self.get_queryset() | |
| return queryset.filter(user=self.request.user).get() | |
| return self.request.user.doctor |
permission으로 의사 구분할거면 이렇게 해도 될 것 같고 아니라면
get_object_or_404라고 원래 get_object에서 사용하는 없으면 404 not found 바로 리턴하는 거 있는데 그거 써도 좋을 것 같아요.
| class ReadOnlyUserSerializer(serializers.ModelSerializer): | ||
| class Meta: | ||
| model = User | ||
| fields = ('id', 'email', 'name', ) |
Member
There was a problem hiding this comment.
readonly면
read_only_fields = fields
추가하면 좋을듯 합니다.
Member
Author
|
확인했습니다. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctor 모듈 GET API 수정
todo