Address review feedback: improve StringWithOptionalLink robustness#7661
Merged
andrew-polk merged 1 commit intoBl-15820TC-new-msgfrom Feb 5, 2026
Merged
Address review feedback: improve StringWithOptionalLink robustness#7661andrew-polk merged 1 commit intoBl-15820TC-new-msgfrom
andrew-polk merged 1 commit intoBl-15820TC-new-msgfrom
Conversation
Copilot
AI
changed the title
[WIP] Update to address feedback from review on BL-15820
Address review feedback: improve StringWithOptionalLink robustness
Feb 5, 2026
andrew-polk
approved these changes
Feb 5, 2026
Co-authored-by: andrew-polk <5847219+andrew-polk@users.noreply.github.com>
andrew-polk
force-pushed
the
copilot/sub-pr-7648
branch
from
0e3f66d to
3b76aad
Compare
andrew-polk
approved these changes
Feb 5, 2026
Contributor
andrew-polk
left a comment
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @copilot[bot]).
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses three approved items from review #3759705782 on PR #7648.
Changes
Updated comment (stringWithOptionalLink.tsx): Clarified that external http/mailto links are now supported and opened via the 'link' API endpoint, not just internal API calls
Fixed regex lastIndex bug (stringWithOptionalLink.tsx): Moved regex instantiation inside component function to prevent stale lastIndex state on re-renders
Added edge case tests (stringWithOptionalLink.spec.tsx): Added coverage for messages with no links, links at start/end, consecutive links, and empty strings
All tests passing (8/8). No security issues detected.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
This change is