Don't create watcher for "other" directory if there isn't one (BL-15838)#7660
Don't create watcher for "other" directory if there isn't one (BL-15838)#7660JohnThomson wants to merge 1 commit intoVersion6.3from
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚩 Pre-existing bug: Dictionary key access without existence check
The color palette merging code at lines 689-702 iterates over repoColorPalettes.Keys and directly accesses localColorPalettes[key] at line 693 without verifying the key exists in localColorPalettes. If the repo's colorPalettes.json contains a palette key that the local file doesn't have, this will throw a KeyNotFoundException.
The MergeColorPaletteValues function (FolderTeamCollection.cs:616-632) does handle null/empty values gracefully, but it never gets called if the dictionary access throws first.
This is pre-existing code, not introduced by this PR, but worth noting as it could cause sync failures when palette files diverge.
(Refers to lines 689-702)
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
This change is