Skip to content

Fix BL-15836 Allow Minimal Book constructor for ErrorBook#7658

Merged
StephenMcConnel merged 1 commit intoVersion6.2from
BL-15836ErrorConstructor
Feb 5, 2026
Merged

Fix BL-15836 Allow Minimal Book constructor for ErrorBook#7658
StephenMcConnel merged 1 commit intoVersion6.2from
BL-15836ErrorConstructor

Conversation

@hatton
Copy link
Member

@hatton hatton commented Feb 5, 2026


Open with Devin

This change is Reviewable

Copilot AI review requested due to automatic review settings February 5, 2026 15:36
@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BL-15836ErrorConstructor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where ErrorBook could not be instantiated in production code due to a guard in the Book base class constructor that only allowed instantiation during unit tests.

Changes:

  • Added a protected Book(bool allowNonTestCtor) constructor to allow specific subclasses to bypass the unit-test guard
  • Modified ErrorBook to call base(true) to use the new constructor path
  • Improved code comments for clarity and consistency

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/BloomExe/Book/Book.cs Added protected constructor with boolean parameter to allow subclasses to bypass unit-test guard; improved comment formatting
src/BloomExe/Book/ErrorBook.cs Modified constructor to call base(true) to bypass guard; improved and cleaned up comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Copy link
Contributor

@StephenMcConnel StephenMcConnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenMcConnel reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @hatton).

@StephenMcConnel StephenMcConnel merged commit 5ca6cde into Version6.2 Feb 5, 2026
8 checks passed
@StephenMcConnel StephenMcConnel deleted the BL-15836ErrorConstructor branch February 5, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants