Add separate control for full bleed layout#7657
Conversation
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 5 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @JohnThomson).
DistFiles/localization/en/BloomMediumPriority.xlf line 778 at r1 (raw file):
<source xml:lang="en">Replace the front cover content with a single full-bleed image. See [Full Page Cover Images](https://docs.bloomlibrary.org/full-page-cover-images) for information on sizing your image to fit.</source> <note>BookSettings.CoverIsImage.Description.V2</note> </trans-unit>
Should v1 above be marked obsolete? Or not yet because we aren't sure we are going with this approach?
Seems like we might as well then everything can be backed out together if we decide to revert.
src/BloomExe/Book/Book.cs line 4053 at r1 (raw file):
public bool FullBleed => PageSizeSupportsFullBleed() && BookInfo.AppearanceSettings.FullBleed
Are we deciding for now not to handle migration? Do we have a note about that somewhere?
src/BloomExe/Book/Book.cs line 4644 at r1 (raw file):
// Device sizes do not support full bleed return !sizeName.StartsWith("Device", System.StringComparison.OrdinalIgnoreCase);
This isn't quite accurate. It should be kept in sync with ConfigureFullBleedPageSize.
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk made 1 comment.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @JohnThomson).
src/BloomExe/Book/Book.cs line 4641 at r1 (raw file):
{ var layout = GetLayout(); var sizeName = layout?.SizeAndOrientation?.PageSizeName ?? "A5";
If we can't determine page size, it seems like we should return false?
25da80c to
1c7ca69
Compare
JohnThomson
left a comment
There was a problem hiding this comment.
@JohnThomson made 4 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @andrew-polk).
DistFiles/localization/en/BloomMediumPriority.xlf line 778 at r1 (raw file):
Previously, andrew-polk wrote…
Should v1 above be marked obsolete? Or not yet because we aren't sure we are going with this approach?
Seems like we might as well then everything can be backed out together if we decide to revert.
Done.
src/BloomExe/Book/Book.cs line 4053 at r1 (raw file):
Previously, andrew-polk wrote…
Are we deciding for now not to handle migration? Do we have a note about that somewhere?
I noted in the card several issues that I did not address, since John indicated that he wants to quickly get this working and see if it helps solve various problems. Effects on 6.2 was one of them.
src/BloomExe/Book/Book.cs line 4641 at r1 (raw file):
Previously, andrew-polk wrote…
If we can't determine page size, it seems like we should return false?
I suppose so. Weird case; we always set some page size, IIRC.
src/BloomExe/Book/Book.cs line 4644 at r1 (raw file):
Previously, andrew-polk wrote…
This isn't quite accurate. It should be kept in sync with ConfigureFullBleedPageSize.
I think the AI did it, and I went along because I thought we now handled all the others. I guess that's 6.4...or maybe I only got part way to handling them all. Done.
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 4 files and all commit messages, and resolved 4 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @JohnThomson).
This change is